From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pavel Machek Subject: Re: [radeon r100] when ring test fails, provide users with option to test Date: Tue, 1 Dec 2015 11:01:10 +0100 Message-ID: <20151201100110.GE21222@amd> References: <20151128205840.GA26757@amd> <565B56A5.4080702@amd.com> <20151129222235.GA25692@amd> <565C0B5A.2040103@amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from atrey.karlin.mff.cuni.cz (atrey.karlin.mff.cuni.cz [195.113.26.193]) by gabe.freedesktop.org (Postfix) with ESMTP id 692C06E7D6 for ; Tue, 1 Dec 2015 02:01:14 -0800 (PST) Content-Disposition: inline In-Reply-To: <565C0B5A.2040103@amd.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Christian =?iso-8859-1?Q?K=F6nig?= Cc: alexander.deucher@amd.com, Trivial patch monkey , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T24gTW9uIDIwMTUtMTEtMzAgMDk6Mzk6NTQsIENocmlzdGlhbiBLw7ZuaWcgd3JvdGU6Cj4gT24g MjkuMTEuMjAxNSAyMzoyMiwgUGF2ZWwgTWFjaGVrIHdyb3RlOgo+ID5PbiBTdW4gMjAxNS0xMS0y OSAyMDo0ODo1MywgQ2hyaXN0aWFuIEvDtm5pZyB3cm90ZToKPiA+Pk9uIDI4LjExLjIwMTUgMjE6 NTgsIFBhdmVsIE1hY2hlayB3cm90ZToKPiA+Pj5SaW5nIHRlc3QgZmFpbHVyZSBpcyBvZnRlbiBj YXVzZWQgYnkgdG9vIGhpZ2ggYWdwbW9kZS4gVGVsbCB0aGUgdXNlcgo+ID4+PndoYXQgdG8gdHJ5 Lgo+ID4+Pgo+ID4+PlNpZ25lZC1vZmYtYnk6IFBhdmVsIE1hY2hlayA8cGF2ZWxAdWN3LmN6Pgo+ ID4+TkFLLCB0aGUgcmluZyB0ZXN0IGNhbiBmYWlsIGZvciBhbnkgbnVtYmVyIG9mIHJlYXNvbnMg YW5kIHRoZSBhZ3Btb2RlIGlzCj4gPj5hY3R1YWxseSByYXRoZXIgdW5saWtlbHkgdG8gYmUgdGhl IGNhdXNlLgo+ID5XZWxsLCB3aGVuIEkgYXNrZWQgb24gdGhlIGxpc3QgIndoeSB0aGlzIGlzIGhh cHBlbmVkIiBJIGdvdCAidW1tLAo+ID5ub29uZSBrbm93cyIgcmVzcG9uc2UgdGhhdCB3YXMgbm90 IGV4YWN0bHkgaGVscGZ1bC4gQW5kIHRoZW4gc29tZW9uZQo+ID50b2xkIG1lIGFib3V0IGFncG1v ZGUuCj4gPgo+ID5JZiB5b3Uga25vdyBhYm91dCB0aGUgcmVhc29ucyBpdCBjYW4gZmFpbCwgY291 bGQgeW91IGxpc3QgdGhlbSBuZWFyCj4gPnRoZSBEUk1fRVJST1IsIGF0IGxlYXN0IGFzIGEgY29t bWVudD8KPiAKPiBXZWxsIGFzIEkgc2FpZCwgdGhhdCBjb3VsZCBiZSBhbnkgbnVtYmVyIG9mIHJl YXNvbnMuIFNvbWUgb2YgdGhlbSBldmVuCj4gY29tcGxldGVseSB1bnJlbGF0ZWQgdG8gdGhlIGRy aXZlciBpdHNlbGYuCj4gCj4gRS5nLiBCSU9TIHNldHRpbmcsIGZhdWx0eSBoYXJkd2FyZSwgcHJv YmxlbXMgd2l0aCB0aGUgd3JpdGViYWNrIGV0Yy4uLiBUaGVyZQo+IGlzIHJlYWxseSBub3QgYSBs aXN0IHlvdSBjb3VsZCBnaXZlIGhlcmUuCj4gCj4gTG93ZXJpbmcgdGhlIGFncG1vZGUgdXN1YWxs eSBoZWxwcyBtb3JlIHRvIHByZXZlbnQgcmFuZG9tIGNvcnJ1cHRpb25zIGFuZAo+IHByb2JsZW1z IHVuZGVyIGxvYWQuCgpUYWtlIGEgbG9vayBhdAoKaHR0cDovL3d3dy5nb3NzYW1lci10aHJlYWRz LmNvbS9saXN0cy9saW51eC9rZXJuZWwvMjE5NzE4MwoKLiBJIGhhZCBhIHByb2JsZW0sIHlvdSBk aWQgbm90IGtub3cgaG93IHRvIGRlYnVnIGl0LCBidXQgaXQgYWxyZWFkeQpoYXBwZW5lZCB0byBw ZWJvbGxlIGF0IHRpc2NhbGkgLi4uIGFuZCB5ZXMsIGl0IHdhcyBhZ3Btb2RlLiBUaGF0CnByb2Js ZW0gaXMgY2xlYXJseSBtb3JlIGNvbW1vbiB0aGVuIHlvdSByZWFsaXplLi4uIFNvIHRoaXMgc2hv dWxkIGdvCmluLgoKCQkJCQkJCQkJUGF2ZWwKCj4gPj4+LS0tIGEvZHJpdmVycy9ncHUvZHJtL3Jh ZGVvbi9yMTAwLmMKPiA+Pj4rKysgYi9kcml2ZXJzL2dwdS9kcm0vcmFkZW9uL3IxMDAuYwo+ID4+ PkBAIC0zNjY1LDcgKzM2NjUsNyBAQCBpbnQgcjEwMF9yaW5nX3Rlc3Qoc3RydWN0IHJhZGVvbl9k ZXZpY2UgKnJkZXYsIHN0cnVjdCByYWRlb25fcmluZyAqcmluZykKPiA+Pj4gIAlpZiAoaSA8IHJk ZXYtPnVzZWNfdGltZW91dCkgewo+ID4+PiAgCQlEUk1fSU5GTygicmluZyB0ZXN0IHN1Y2NlZWRl ZCBpbiAlZCB1c2Vjc1xuIiwgaSk7Cj4gPj4+ICAJfSBlbHNlIHsKPiA+Pj4tCQlEUk1fRVJST1Io InJhZGVvbjogcmluZyB0ZXN0IGZhaWxlZCAoc2NyYXRjaCgweCUwNFgpPTB4JTA4WClcbiIsCj4g Pj4+KwkJRFJNX0VSUk9SKCJyYWRlb246IHJpbmcgdGVzdCBmYWlsZWQgKHNjcmF0Y2goMHglMDRY KT0weCUwOFgpLCB0cnkgcmFkZW9uLmFncG1vZGU9MT9cbiIsCj4gPj4+ICAJCQkgIHNjcmF0Y2gs IHRtcCk7Cj4gPj4+ICAJCXIgPSAtRUlOVkFMOwo+ID4+PiAgCX0KPiA+Pj4KCi0tIAooZW5nbGlz aCkgaHR0cDovL3d3dy5saXZlam91cm5hbC5jb20vfnBhdmVsbWFjaGVrCihjZXNreSwgcGljdHVy ZXMpIGh0dHA6Ly9hdHJleS5rYXJsaW4ubWZmLmN1bmkuY3ovfnBhdmVsL3BpY3R1cmUvaG9yc2Vz L2Jsb2cuaHRtbApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f XwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcK aHR0cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756160AbbLAKBR (ORCPT ); Tue, 1 Dec 2015 05:01:17 -0500 Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]:33845 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755027AbbLAKBN (ORCPT ); Tue, 1 Dec 2015 05:01:13 -0500 Date: Tue, 1 Dec 2015 11:01:10 +0100 From: Pavel Machek To: Christian =?iso-8859-1?Q?K=F6nig?= Cc: Trivial patch monkey , alexander.deucher@amd.com, airlied@linux.ie, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [radeon r100] when ring test fails, provide users with option to test Message-ID: <20151201100110.GE21222@amd> References: <20151128205840.GA26757@amd> <565B56A5.4080702@amd.com> <20151129222235.GA25692@amd> <565C0B5A.2040103@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <565C0B5A.2040103@amd.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon 2015-11-30 09:39:54, Christian König wrote: > On 29.11.2015 23:22, Pavel Machek wrote: > >On Sun 2015-11-29 20:48:53, Christian König wrote: > >>On 28.11.2015 21:58, Pavel Machek wrote: > >>>Ring test failure is often caused by too high agpmode. Tell the user > >>>what to try. > >>> > >>>Signed-off-by: Pavel Machek > >>NAK, the ring test can fail for any number of reasons and the agpmode is > >>actually rather unlikely to be the cause. > >Well, when I asked on the list "why this is happened" I got "umm, > >noone knows" response that was not exactly helpful. And then someone > >told me about agpmode. > > > >If you know about the reasons it can fail, could you list them near > >the DRM_ERROR, at least as a comment? > > Well as I said, that could be any number of reasons. Some of them even > completely unrelated to the driver itself. > > E.g. BIOS setting, faulty hardware, problems with the writeback etc... There > is really not a list you could give here. > > Lowering the agpmode usually helps more to prevent random corruptions and > problems under load. Take a look at http://www.gossamer-threads.com/lists/linux/kernel/2197183 . I had a problem, you did not know how to debug it, but it already happened to pebolle at tiscali ... and yes, it was agpmode. That problem is clearly more common then you realize... So this should go in. Pavel > >>>--- a/drivers/gpu/drm/radeon/r100.c > >>>+++ b/drivers/gpu/drm/radeon/r100.c > >>>@@ -3665,7 +3665,7 @@ int r100_ring_test(struct radeon_device *rdev, struct radeon_ring *ring) > >>> if (i < rdev->usec_timeout) { > >>> DRM_INFO("ring test succeeded in %d usecs\n", i); > >>> } else { > >>>- DRM_ERROR("radeon: ring test failed (scratch(0x%04X)=0x%08X)\n", > >>>+ DRM_ERROR("radeon: ring test failed (scratch(0x%04X)=0x%08X), try radeon.agpmode=1?\n", > >>> scratch, tmp); > >>> r = -EINVAL; > >>> } > >>> -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html