From: Mark Brown <broonie@kernel.org>
To: mengdong.lin@linux.intel.com
Cc: alsa-devel@alsa-project.org, vinod.koul@intel.com,
mengdong.lin@intel.com, liam.r.girdwood@linux.intel.com,
jeeja.kp@intel.com, subhransu.s.prusty@intel.com
Subject: Re: [PATCH 3/3] ASoC: Implement DAI links in a list & define API to add/remove a link
Date: Tue, 1 Dec 2015 15:58:47 +0000 [thread overview]
Message-ID: <20151201155847.GL1929@sirena.org.uk> (raw)
In-Reply-To: <91d3898f62702fa255fc82c9cc3d1d14a1208263.1448294077.git.mengdong.lin@linux.intel.com>
[-- Attachment #1.1: Type: text/plain, Size: 573 bytes --]
On Mon, Nov 23, 2015 at 11:04:04AM -0500, mengdong.lin@linux.intel.com wrote:
A couple of small things but otherwise this looks fine:
> + struct snd_soc_dai_link *dai_link; /* predefined links only */
> + int num_links; /* predefined links only */
> + struct list_head dai_link_list; /* all links */
> + int num_dai_links;
Why are we keeping a count of num_dai_links? I can't see any users.
> + /* add predefined DAI links to the list */
> + for (i = 0; i < card->num_links; i++)
> + snd_soc_add_dai_link(card, card->dai_link+i);
Missing spaces around the + here.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
prev parent reply other threads:[~2015-12-01 15:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-23 15:59 [PATCH 0/3] ASoC: Implement DAI links in a list & some code refactoring mengdong.lin
2015-11-23 16:01 ` [PATCH 1/3] ASoC: Define soc_init_dai_link() to wrap link intialization mengdong.lin
2015-11-23 16:03 ` [PATCH 2/3] ASoC: Change 2nd argument of soc_bind_dai_link() to DAI link pointer mengdong.lin
2015-11-23 16:04 ` [PATCH 3/3] ASoC: Implement DAI links in a list & define API to add/remove a link mengdong.lin
2015-12-01 15:58 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151201155847.GL1929@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=jeeja.kp@intel.com \
--cc=liam.r.girdwood@linux.intel.com \
--cc=mengdong.lin@intel.com \
--cc=mengdong.lin@linux.intel.com \
--cc=subhransu.s.prusty@intel.com \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.