From mboxrd@z Thu Jan  1 00:00:00 1970
From: Wei Liu <wei.liu2@citrix.com>
Subject: Re: [PATCH v2] libxl: Introduce a template for devices
 with a controller
Date: Tue, 1 Dec 2015 17:25:28 +0000
Message-ID: <20151201172528.GA21588@citrix.com>
References: <1448971798-3498-1-git-send-email-george.dunlap@eu.citrix.com>
	<20151201155855.GX21588@citrix.com>
	<CAFLBxZaf+CoxXAMAi0Hunjr5NP5fkSrM9PZdasW8YajS0R9AQg@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Content-Disposition: inline
In-Reply-To: <CAFLBxZaf+CoxXAMAi0Hunjr5NP5fkSrM9PZdasW8YajS0R9AQg@mail.gmail.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: George Dunlap <George.Dunlap@eu.citrix.com>
Cc: Juergen Gross <jgross@suse.com>, Olaf Hering <olaf@aepfle.de>, Wei Liu <wei.liu2@citrix.com>, Ian Campbell <ian.campbell@citrix.com>, George Dunlap <george.dunlap@citrix.com>, "xen-devel@lists.xen.org" <xen-devel@lists.xen.org>, Ian Jackson <ian.jackson@citrix.com>, Chun Yan Liu <cyliu@suse.com>
List-Id: xen-devel@lists.xenproject.org

On Tue, Dec 01, 2015 at 05:03:28PM +0000, George Dunlap wrote:
> On Tue, Dec 1, 2015 at 3:58 PM, Wei Liu <wei.liu2@citrix.com> wrote:
> > On Tue, Dec 01, 2015 at 12:09:58PM +0000, George Dunlap wrote:
> > [...]
> >> diff --git a/tools/libxl/libxl.h b/tools/libxl/libxl.h
> >> index 6b73848..44e2951 100644
> >> --- a/tools/libxl/libxl.h
> >> +++ b/tools/libxl/libxl.h
> >> @@ -1396,6 +1396,71 @@ void libxl_vtpminfo_list_free(libxl_vtpminfo *, int nr_vtpms);
> >>   *
> >>   *   This function does not interact with the guest and therefore
> >>   *   cannot block on the guest.
> >> + *
> >> + * Controllers
> >> + * -----------
> >> + *
> >> + * Most devices are treated individually.  Some classes of device,
> >> + * however, like USB or SCSI, inherently have the need to have a
> >> + * hierarchy of different levels, with lower-level devices "attached"
> >> + * to higher-level ones.  USB for instance has "controllers" at the
> >> + * top, which have buses, on which are devices, which consist of
> >> + * multiple interfaces.  SCSI has "hosts" at the top, then buses,
> >> + * targets, and LUNs.
> >> + *
> >> + * In that case, for each <class>, there will be a set of functions
> >> + * and types for each <level>.  For example, for <class>=usb, there
> >> + * may be <levels> ctrl (controller) and dev (device), with ctrl being
> >> + * level 0.
> >> + *
> >> + * libxl_device_<class><level0>_<function> will act more or
> >
> > Missed "level0" comment from Chunyan?
> 
> The only comment of Chunyan's I could find that has <level0> in it is
> actually correcting <type><level0> => <class><level0>.  Did I
> misunderstand, or did you? :-)

Oops. I misread. Sorry about the noise.

Wei.

> 
>  -George