From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] arm: socfpga: arria10: add additional i2c nodes for Arria10
Date: Tue, 1 Dec 2015 19:41:05 +0100 [thread overview]
Message-ID: <201512011941.05669.marex@denx.de> (raw)
In-Reply-To: <565DD500.8090706@denx.de>
On Tuesday, December 01, 2015 at 06:12:32 PM, Stefan Roese wrote:
> On 01.12.2015 17:41, dinguyen at opensource.altera.com wrote:
> > From: Dinh Nguyen <dinguyen@opensource.altera.com>
> >
> > Add remaining 3 I2C base addresses for the Arria10.
> >
> > Signed-off-by: Dinh Nguyen <dinguyen@opensource.altera.com>
> > ---
> >
> > arch/arm/mach-socfpga/include/mach/base_addr_a10.h | 4 ++++
> > 1 file changed, 4 insertions(+)
> >
> > diff --git a/arch/arm/mach-socfpga/include/mach/base_addr_a10.h
> > b/arch/arm/mach-socfpga/include/mach/base_addr_a10.h index
> > a7056d4..8653dd5 100644
> > --- a/arch/arm/mach-socfpga/include/mach/base_addr_a10.h
> > +++ b/arch/arm/mach-socfpga/include/mach/base_addr_a10.h
> > @@ -29,6 +29,10 @@
> >
> > #define SOCFPGA_MPUL2_ADDRESS 0xfffff000
> > #define SOCFPGA_I2C0_ADDRESS 0xffc02200
> > #define SOCFPGA_I2C1_ADDRESS 0xffc02300
> >
> > +#define SOCFPGA_I2C2_ADDRESS 0xffc02400
> > +#define SOCFPGA_I2C3_ADDRESS 0xffc02500
> > +#define SOCFPGA_I2C4_ADDRESS 0xffc02600
> > +
> >
> > #define SOCFPGA_ECC_OCRAM_ADDRESS 0xff8c3000
> > #define SOCFPGA_UART0_ADDRESS 0xffc02000
>
> Nitpicking, but there seems to be one empty line too much
> added above.
>
> Other than this:
>
> Reviewed-by: Stefan Roese <sr@denx.de>
>
> BTW: Is anyone working on DM conversion of this I2C driver? All
> those macros for the base addresses would not be needed then.
Fixed and applied.
Best regards,
Marek Vasut
next prev parent reply other threads:[~2015-12-01 18:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-01 16:41 [U-Boot] [PATCH] arm: socfpga: arria10: add additional i2c nodes for Arria10 dinguyen at opensource.altera.com
2015-12-01 17:12 ` Stefan Roese
2015-12-01 18:41 ` Marek Vasut [this message]
2015-12-02 5:36 ` Chin Liang See
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201512011941.05669.marex@denx.de \
--to=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.