From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: [PATCH 10/10] ARM: dts: Fix dm814x pinctrl address and mask Date: Tue, 1 Dec 2015 16:46:24 -0800 Message-ID: <20151202004623.GX23396@atomide.com> References: <1449013103-23238-1-git-send-email-tony@atomide.com> <1449013103-23238-11-git-send-email-tony@atomide.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Matthijs van Duin Cc: lkml , "linux-omap@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , Brian Hutchinson , Delio Brignoli , Neil Armstrong , Philipp Rosenberger List-Id: linux-omap@vger.kernel.org * Matthijs van Duin [151201 16:26]: > On 2 December 2015 at 00:38, Tony Lindgren wrote: > > - pinctrl-single,function-mask = <0x300ff>; > > + pinctrl-single,function-mask = <0x707ff>; > > Reminder that silicon revision 2.1 and older require input enabled > (bit 18 set) for all 3.3V I/Os to avoid cumulative hardware damage. > (Errata advisory 2.1.87) Ouch. We should probably have separate PIN_INPUT_3V3 and PIN_OUTPUT_3V3 dts macros that ensure that? Regards, Tony From mboxrd@z Thu Jan 1 00:00:00 1970 From: tony@atomide.com (Tony Lindgren) Date: Tue, 1 Dec 2015 16:46:24 -0800 Subject: [PATCH 10/10] ARM: dts: Fix dm814x pinctrl address and mask In-Reply-To: References: <1449013103-23238-1-git-send-email-tony@atomide.com> <1449013103-23238-11-git-send-email-tony@atomide.com> Message-ID: <20151202004623.GX23396@atomide.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org * Matthijs van Duin [151201 16:26]: > On 2 December 2015 at 00:38, Tony Lindgren wrote: > > - pinctrl-single,function-mask = <0x300ff>; > > + pinctrl-single,function-mask = <0x707ff>; > > Reminder that silicon revision 2.1 and older require input enabled > (bit 18 set) for all 3.3V I/Os to avoid cumulative hardware damage. > (Errata advisory 2.1.87) Ouch. We should probably have separate PIN_INPUT_3V3 and PIN_OUTPUT_3V3 dts macros that ensure that? Regards, Tony