From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yuanhan Liu Subject: Re: [PATCH 3/4] vhost: log vring changes Date: Wed, 2 Dec 2015 22:38:02 +0800 Message-ID: <20151202143802.GT2325@yliu-dev.sh.intel.com> References: <1449027793-30975-1-git-send-email-yuanhan.liu@linux.intel.com> <1449027793-30975-4-git-send-email-yuanhan.liu@linux.intel.com> <20151202155405-mutt-send-email-victork@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: dev@dpdk.org, "Michael S. Tsirkin" To: Victor Kaplansky Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id A0E185683 for ; Wed, 2 Dec 2015 15:34:36 +0100 (CET) Content-Disposition: inline In-Reply-To: <20151202155405-mutt-send-email-victork@redhat.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Dec 02, 2015 at 04:07:02PM +0200, Victor Kaplansky wrote: > On Wed, Dec 02, 2015 at 11:43:12AM +0800, Yuanhan Liu wrote: > > Invoking vhost_log_write() to mark corresponding page as dirty while > > updating used vring. > > Looks good, thanks! > > I didn't find where you log the dirty pages in result of data > written to the buffers pointed by the descriptors in RX vring. > AFAIU, the buffers of RX queue reside in guest's memory and have > to be marked as dirty if they are written. What do you say? Yeah, we should. I got a question then: why log_guest_addr is set to the physical address of used vring in guest? I mean, apparently, we need log more changes other than used vring only. --yliu