Re: [PATCH 0/3] add lpm support for NEON

[Jerin Jacob <jerin.jacob@caviumnetworks.com>]

On Wed, Dec 02, 2015 at 02:43:12PM +0100, Jan Viktorin wrote:
> Hello Jerin,
> 
> thank you for this patch series. Please CC me next time when doing an
> ARM-related changes. It took me a while to find the related e-mails on
> the mail server.

It's was my mistake. Sorry about that.


> 
> On Mon, 30 Nov 2015 22:54:10 +0530
> Jerin Jacob <jerin.jacob@caviumnetworks.com> wrote:
> 
> > - Introduce new rte_vect_* abstractions in eal
> > - This patch set has the changes required for optimised pm library usage in arm64 perspective
> > - Tested on Juno and Thunder boards
> > - Tested and verified the changes with following DPDK unit test cases
> > 	--lpm_autotest
> > 	--lpm6_autotest
> > - This patch set has dependency on [dpdk-dev] [PATCH v4 0/2] disable CONFIG_RTE_SCHED_VECTOR for arm
> 
> What kind of dependency is it? Functional?

Not functional, Just "git am" dependency on config file change due to recent config file
re structuring.


> 
> > - With these changes, arm64 platform supports all DPDK libraries(in feature wise)
> 
> Is there some ARMv8 specific NEON instruction?

NO. I just said as covering note as ACL on armv7 was not supported at
that time.


> 
> > 
> > Jerin Jacob (3):
> >   eal: introduce rte_vect_* abstractions
> >   lpm: add support for NEON
> >   maintainers: claim responsibility for arm64 specific files of hash and
> >     lpm
> > 
> >  MAINTAINERS                                       |   3 +
> >  app/test/test_lpm.c                               |  10 +-
> >  config/defconfig_arm64-armv8a-linuxapp-gcc        |   3 -
> >  lib/librte_eal/common/include/arch/arm/rte_vect.h |  17 ++-
> >  lib/librte_eal/common/include/arch/x86/rte_vect.h |   8 +
> >  lib/librte_lpm/Makefile                           |   3 +
> >  lib/librte_lpm/rte_lpm.h                          |   5 +
> >  lib/librte_lpm/rte_lpm_neon.h                     | 172 ++++++++++++++++++++++
> >  8 files changed, 212 insertions(+), 9 deletions(-)
> >  create mode 100644 lib/librte_lpm/rte_lpm_neon.h
> > 
> > --
> > 2.1.0
> > 
> 
> 
> 
> -- 
>    Jan Viktorin                  E-mail: Viktorin@RehiveTech.com
>    System Architect              Web:    www.RehiveTech.com
>    RehiveTech
>    Brno, Czech Republic