[dm:for-next 11/11] drivers/md/dm-verity.c:737:31: warning: passing argument 2 of 'dm_read_arg_group' from incompatible pointer type

[dm:for-next 11/11] drivers/md/dm-verity.c:737:31: warning: passing argument 2 of 'dm_read_arg_group' from incompatible pointer type

[kbuild test robot]

[-- Attachment #1: Type: text/plain, Size: 3466 bytes --]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/device-mapper/linux-dm.git for-next
head:   81d42f18b9ca93f6d182692c6edf4ad604e95964
commit: 81d42f18b9ca93f6d182692c6edf4ad604e95964 [11/11] dm verity: separate function for parsing opt args
config: i386-randconfig-x005-12020835 (attached as .config)
reproduce:
        git checkout 81d42f18b9ca93f6d182692c6edf4ad604e95964
        # save the attached .config to linux build tree
        make ARCH=i386 

All warnings (new ones prefixed by >>):

   drivers/md/dm-verity.c: In function 'verity_parse_opt_args':
>> drivers/md/dm-verity.c:737:31: warning: passing argument 2 of 'dm_read_arg_group' from incompatible pointer type [-Wincompatible-pointer-types]
     r = dm_read_arg_group(_args, &as, &argc, &ti->error);
                                  ^
   In file included from drivers/md/dm-verity.c:20:0:
   include/linux/device-mapper.h:345:5: note: expected 'struct dm_arg_set *' but argument is of type 'struct dm_arg_set **'
    int dm_read_arg_group(struct dm_arg *arg, struct dm_arg_set *arg_set,
        ^
>> drivers/md/dm-verity.c:745:27: warning: passing argument 1 of 'dm_shift_arg' from incompatible pointer type [-Wincompatible-pointer-types]
      arg_name = dm_shift_arg(&as);
                              ^
   In file included from drivers/md/dm-verity.c:20:0:
   include/linux/device-mapper.h:351:13: note: expected 'struct dm_arg_set *' but argument is of type 'struct dm_arg_set **'
    const char *dm_shift_arg(struct dm_arg_set *as);
                ^
   drivers/md/dm-verity.c: In function 'verity_ctr':
>> drivers/md/dm-verity.c:782:14: warning: unused variable 'opt_string' [-Wunused-variable]
     const char *opt_string;
                 ^

vim +/dm_read_arg_group +737 drivers/md/dm-verity.c

   731		const char *arg_name;
   732	
   733		static struct dm_arg _args[] = {
   734			{0, DM_VERITY_OPTS_MAX, "Invalid number of feature args"},
   735		};
   736	
 > 737		r = dm_read_arg_group(_args, &as, &argc, &ti->error);
   738		if (r)
   739			return -EINVAL;
   740	
   741		if (!argc)
   742			return 0;
   743	
   744		do {
 > 745			arg_name = dm_shift_arg(&as);
   746			argc--;
   747	
   748			if (!strcasecmp(arg_name, DM_VERITY_OPT_LOGGING)) {
   749				v->mode = DM_VERITY_MODE_LOGGING;
   750				continue;
   751	
   752			} else if (!strcasecmp(arg_name, DM_VERITY_OPT_RESTART)) {
   753				v->mode = DM_VERITY_MODE_RESTART;
   754				continue;
   755			}
   756	
   757			ti->error = "Unrecognized verity feature request";
   758			return -EINVAL;
   759		} while (argc && !r);
   760	
   761		return r;
   762	}
   763	
   764	/*
   765	 * Target parameters:
   766	 *	<version>	The current format is version 1.
   767	 *			Vsn 0 is compatible with original Chromium OS releases.
   768	 *	<data device>
   769	 *	<hash device>
   770	 *	<data block size>
   771	 *	<hash block size>
   772	 *	<the number of data blocks>
   773	 *	<hash start block>
   774	 *	<algorithm>
   775	 *	<digest>
   776	 *	<salt>		Hex string or "-" if no salt.
   777	 */
   778	static int verity_ctr(struct dm_target *ti, unsigned argc, char **argv)
   779	{
   780		struct dm_verity *v;
   781		struct dm_arg_set as;
 > 782		const char *opt_string;
   783		unsigned int num;
   784		unsigned long long num_ll;
   785		int r;

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/octet-stream, Size: 23008 bytes --]

[-- Attachment #3: Type: text/plain, Size: 0 bytes --]

Re: [dm:for-next 11/11] drivers/md/dm-verity.c:737:31: warning: passing argument 2 of 'dm_read_arg_group' from incompatible pointer type

[Mike Snitzer]

On Wed, Dec 02 2015 at  3:40pm -0500,
kbuild test robot <fengguang.wu@intel.com> wrote:

> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/device-mapper/linux-dm.git for-next
> head:   81d42f18b9ca93f6d182692c6edf4ad604e95964
> commit: 81d42f18b9ca93f6d182692c6edf4ad604e95964 [11/11] dm verity: separate function for parsing opt args
> config: i386-randconfig-x005-12020835 (attached as .config)
> reproduce:
>         git checkout 81d42f18b9ca93f6d182692c6edf4ad604e95964
>         # save the attached .config to linux build tree
>         make ARCH=i386 
> 
> All warnings (new ones prefixed by >>):
> 
>    drivers/md/dm-verity.c: In function 'verity_parse_opt_args':
> >> drivers/md/dm-verity.c:737:31: warning: passing argument 2 of 'dm_read_arg_group' from incompatible pointer type [-Wincompatible-pointer-types]
>      r = dm_read_arg_group(_args, &as, &argc, &ti->error);
>                                   ^

I've fixed this up, sorry for the noise.