From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: "Geyslan G. Bem" <geyslan@gmail.com>
Cc: peter.senna@gmail.com, Alan Stern <stern@rowland.harvard.edu>,
Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Michal Hocko <mhocko@suse.com>,
Andrew Morton <akpm@linux-foundation.org>,
Masanari Iida <standby24x7@gmail.com>,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
Saurabh Karajgaonkar <skarajga@visteon.com>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] usb: ehci: ohci: use true/false for bool
Date: Wed, 2 Dec 2015 13:58:51 -0800 [thread overview]
Message-ID: <20151202215851.GC31125@kroah.com> (raw)
In-Reply-To: <1449093046-22039-1-git-send-email-geyslan@gmail.com>
On Wed, Dec 02, 2015 at 06:50:41PM -0300, Geyslan G. Bem wrote:
> When bool use true or false instead of 1 or 0.
>
> Caught by coccinelle.
>
> Signed-off-by: Geyslan G. Bem <geyslan@gmail.com>
> ---
> drivers/usb/host/ehci-hcd.c | 2 +-
> drivers/usb/host/ohci-hcd.c | 4 ++--
> drivers/usb/host/u132-hcd.c | 2 +-
> 3 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/usb/host/ehci-hcd.c b/drivers/usb/host/ehci-hcd.c
> index 48c92bf..1b01967 100644
> --- a/drivers/usb/host/ehci-hcd.c
> +++ b/drivers/usb/host/ehci-hcd.c
> @@ -98,7 +98,7 @@ module_param (park, uint, S_IRUGO);
> MODULE_PARM_DESC (park, "park setting; 1-3 back-to-back async packets");
>
> /* for flakey hardware, ignore overcurrent indicators */
> -static bool ignore_oc = 0;
> +static bool ignore_oc = false;
No need to set this to "0/false" as that's what the default is.
thanks,
greg k-h
next prev parent reply other threads:[~2015-12-02 21:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-02 21:50 [PATCH] usb: ehci: ohci: use true/false for bool Geyslan G. Bem
2015-12-02 21:58 ` Greg Kroah-Hartman [this message]
2015-12-02 22:09 ` Geyslan G. Bem
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151202215851.GC31125@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=akpm@linux-foundation.org \
--cc=geyslan@gmail.com \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mhocko@suse.com \
--cc=peter.senna@gmail.com \
--cc=rafael.j.wysocki@intel.com \
--cc=sergei.shtylyov@cogentembedded.com \
--cc=skarajga@visteon.com \
--cc=standby24x7@gmail.com \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.