From: Daniel Vetter <daniel@ffwll.ch>
To: Philipp Zabel <p.zabel@pengutronix.de>
Cc: dri-devel@lists.freedesktop.org, kernel@pengutronix.de
Subject: Re: [PATCH] drm_modes: calculate nominal vrefresh in drm_display_mode_from_videomode
Date: Thu, 3 Dec 2015 10:50:07 +0100 [thread overview]
Message-ID: <20151203095007.GO10243@phenom.ffwll.local> (raw)
In-Reply-To: <1449132944-29869-1-git-send-email-p.zabel@pengutronix.de>
On Thu, Dec 03, 2015 at 09:55:44AM +0100, Philipp Zabel wrote:
> Use drm_mode_vrefresh to update the vrefresh field after changing the
> modes' timings and flags.
>
> Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
> ---
> drivers/gpu/drm/drm_modes.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/drm_modes.c b/drivers/gpu/drm/drm_modes.c
> index cd74a09..b624be8 100644
> --- a/drivers/gpu/drm/drm_modes.c
> +++ b/drivers/gpu/drm/drm_modes.c
> @@ -611,6 +611,8 @@ void drm_display_mode_from_videomode(const struct videomode *vm,
> dmode->flags |= DRM_MODE_FLAG_DBLSCAN;
> if (vm->flags & DISPLAY_FLAGS_DOUBLECLK)
> dmode->flags |= DRM_MODE_FLAG_DBLCLK;
> + dmode->vrefresh = 0;
Rendundant. Or I'm blind.
-Daniel
> + dmode->vrefresh = drm_mode_vrefresh(dmode);
> drm_mode_set_name(dmode);
> }
> EXPORT_SYMBOL_GPL(drm_display_mode_from_videomode);
> --
> 2.6.2
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2015-12-03 9:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-03 8:55 [PATCH] drm_modes: calculate nominal vrefresh in drm_display_mode_from_videomode Philipp Zabel
2015-12-03 9:50 ` Daniel Vetter [this message]
2015-12-03 10:22 ` Thierry Reding
2015-12-03 11:09 ` Philipp Zabel
2015-12-04 7:57 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151203095007.GO10243@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=kernel@pengutronix.de \
--cc=p.zabel@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.