From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thierry Reding Subject: Re: [PATCH] drm_modes: calculate nominal vrefresh in drm_display_mode_from_videomode Date: Thu, 3 Dec 2015 11:22:50 +0100 Message-ID: <20151203102250.GA22213@ulmo.nvidia.com> References: <1449132944-29869-1-git-send-email-p.zabel@pengutronix.de> <20151203095007.GO10243@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============2090723506==" Return-path: Received: from mail-pa0-f42.google.com (mail-pa0-f42.google.com [209.85.220.42]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6E94C7A0EA for ; Thu, 3 Dec 2015 02:22:54 -0800 (PST) Received: by pacdm15 with SMTP id dm15so66695344pac.3 for ; Thu, 03 Dec 2015 02:22:54 -0800 (PST) In-Reply-To: <20151203095007.GO10243@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Daniel Vetter Cc: kernel@pengutronix.de, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============2090723506== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="jI8keyz6grp/JLjh" Content-Disposition: inline --jI8keyz6grp/JLjh Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Dec 03, 2015 at 10:50:07AM +0100, Daniel Vetter wrote: > On Thu, Dec 03, 2015 at 09:55:44AM +0100, Philipp Zabel wrote: > > Use drm_mode_vrefresh to update the vrefresh field after changing the > > modes' timings and flags. > >=20 > > Signed-off-by: Philipp Zabel > > --- > > drivers/gpu/drm/drm_modes.c | 2 ++ > > 1 file changed, 2 insertions(+) > >=20 > > diff --git a/drivers/gpu/drm/drm_modes.c b/drivers/gpu/drm/drm_modes.c > > index cd74a09..b624be8 100644 > > --- a/drivers/gpu/drm/drm_modes.c > > +++ b/drivers/gpu/drm/drm_modes.c > > @@ -611,6 +611,8 @@ void drm_display_mode_from_videomode(const struct v= ideomode *vm, > > dmode->flags |=3D DRM_MODE_FLAG_DBLSCAN; > > if (vm->flags & DISPLAY_FLAGS_DOUBLECLK) > > dmode->flags |=3D DRM_MODE_FLAG_DBLCLK; > > + dmode->vrefresh =3D 0; >=20 > Rendundant. Or I'm blind. Unfortunately it isn't. drm_mode_vrefresh() is somewhat odd in that it'll return the existing mode->vrefresh if it is > 0. I'm thinking that perhaps it'd be useful to factor out the computation code into a separate function, say drm_mode_calc_vrefresh(), and use that where you really want to compute the value and at the same time use it to simplify drm_mode_vrefresh() as well. Thierry --jI8keyz6grp/JLjh Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAABCAAGBQJWYBf2AAoJEN0jrNd/PrOhSJUP/0jUCWA1Dr3NsWJALyw0JL4L Pp9nqTYOFI2+l93SWfts65xOCwQ23ghL1tPUS1508rVnCdM9+IMBLsCEjsE6Gl6s /dzHofBp25dCSfh12LzYMshE7Z9k7mWgn3muoODxA4/vbsMmudu2BJ70QghowR8D ygUKI+ft9kKWpCsMejtLy7QGgtVGSluiIQI+C+p8lY+07u7Hl1BXJYUp93bAqO+Q uBJxO3wFpa/1coadJFJhkcUI7DMGW/L715pFMmvlYsqP/gXQLSwrE4nri1wyADV0 MnXKNOawIVFs1iO3Gq2S58h3xlrUEN68pPgTnxhje6sORlBynnhcFN0xX/ZEMs2N ndhZyzTfaTrV48X4n+jvX7csTlSvKEt7efAVXoDoMYNXzOGIKHkqA5V0bYl8Ms6f V+ALTmaDBAHzgvko89mpZyJmUk2Q/Pbt6jDAssKo9pvpc5R9WmcG6gm0mFVLx22i zv/75r0ZO2QrsnpF/KpoqEqgWH/pwsGuaAdagdxJ3oM1tyLBRXohM5aWLvd3Y+vq m12IuGK/GTJ3PqjG3i+fQ3SCFxUFOY6+FbIaB1MArj/sw1ledHc+Q3MRSqH93exV yePq7+EIc4APW8UCkuwCG3tcCZ+anJN0KsYOOtmgXbYnHynnznhFBkubPT+GXZ9X mhM+EW7eTj2pHxoYJpkq =fMRy -----END PGP SIGNATURE----- --jI8keyz6grp/JLjh-- --===============2090723506== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0 cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK --===============2090723506==--