From: Wolfram Sang <wsa@the-dreams.de>
To: Jarkko Nikula <jarkko.nikula@linux.intel.com>
Cc: linux-i2c@vger.kernel.org
Subject: Re: [PATCH RESEND] i2c: Remove setting for 1 second timeout from adapter drivers
Date: Thu, 3 Dec 2015 21:52:28 +0100 [thread overview]
Message-ID: <20151203205228.GC8509@katana> (raw)
In-Reply-To: <1449054154-32273-1-git-send-email-jarkko.nikula@linux.intel.com>
[-- Attachment #1: Type: text/plain, Size: 466 bytes --]
On Wed, Dec 02, 2015 at 01:02:34PM +0200, Jarkko Nikula wrote:
> I2C adapter drivers that are using 1 second timeout can leave the timeout
> unset and let the i2c-core.c: i2c_register_adapter() to set it instead.
>
> Signed-off-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
My take on this is that I prefer the explicit (and thus visible)
assignment. What the core does was intended as a fallback to prevent
strange things happening with a 0 value.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2015-12-03 20:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-02 11:02 [PATCH RESEND] i2c: Remove setting for 1 second timeout from adapter drivers Jarkko Nikula
2015-12-03 20:52 ` Wolfram Sang [this message]
2015-12-04 8:01 ` Jarkko Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151203205228.GC8509@katana \
--to=wsa@the-dreams.de \
--cc=jarkko.nikula@linux.intel.com \
--cc=linux-i2c@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.