All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: Markus Pargmann <mpa@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 5/9] lib: Import reed solomon code from kernel
Date: Fri, 4 Dec 2015 08:12:55 +0100	[thread overview]
Message-ID: <20151204071255.GS11966@pengutronix.de> (raw)
In-Reply-To: <1449064131-12659-6-git-send-email-mpa@pengutronix.de>

On Wed, Dec 02, 2015 at 02:48:47PM +0100, Markus Pargmann wrote:
> reed solomon code is used by RAMOOPS to check and fix data stored in
> volatile memory.
> 
> Signed-off-by: Markus Pargmann <mpa@pengutronix.de>
> ---
>  include/linux/rslib.h           | 109 ++++++++++++
>  lib/Kconfig                     |  15 ++
>  lib/Makefile                    |   1 +
>  lib/reed_solomon/Makefile       |   6 +
>  lib/reed_solomon/decode_rs.c    | 271 +++++++++++++++++++++++++++++
>  lib/reed_solomon/encode_rs.c    |  54 ++++++
>  lib/reed_solomon/reed_solomon.c | 377 ++++++++++++++++++++++++++++++++++++++++
>  7 files changed, 833 insertions(+)
>  create mode 100644 include/linux/rslib.h
>  create mode 100644 lib/reed_solomon/Makefile
>  create mode 100644 lib/reed_solomon/decode_rs.c
>  create mode 100644 lib/reed_solomon/encode_rs.c
>  create mode 100644 lib/reed_solomon/reed_solomon.c
> 

> diff --git a/lib/Kconfig b/lib/Kconfig
> index fbf9f0f34849..f2f3b5775ace 100644
> --- a/lib/Kconfig
> +++ b/lib/Kconfig
> @@ -22,6 +22,21 @@ config XZ_DECOMPRESS
>  	bool "include xz uncompression support"
>  	select UNCOMPRESS
>  
> +config REED_SOLOMON
> +	bool
> +
> +config REED_SOLOMON_ENC8
> +	bool
> +
> +config REED_SOLOMON_DEC8
> +	bool
> +
> +config REED_SOLOMON_ENC16
> +	bool
> +
> +config REED_SOLOMON_DEC16
> +	bool
> +

These fine grained config options seem unnecessary. Can we limit this to
a single config REED_SOLOMON only? The linker will discard unused
symbols anyway.

Sascha



-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2015-12-04  7:13 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-02 13:48 [PATCH 0/9] RAMOOPS read support for Barebox Markus Pargmann
2015-12-02 13:48 ` [PATCH 1/9] arm: boards: karo-tx6x remove definition of DIV_ROUND_UP Markus Pargmann
2015-12-02 13:48 ` [PATCH 2/9] log2: Add missing __rounddown_pow_of_two() Markus Pargmann
2015-12-02 13:48 ` [PATCH 3/9] printk: Add missing include/declaration Markus Pargmann
2015-12-02 13:48 ` [PATCH 4/9] vsprintf: Add scnprintf from kernel Markus Pargmann
2015-12-02 13:48 ` [PATCH 5/9] lib: Import reed solomon code " Markus Pargmann
2015-12-04  7:12   ` Sascha Hauer [this message]
2015-12-04 13:22     ` Markus Pargmann
2015-12-02 13:48 ` [PATCH 6/9] arm: Clarify memory layout calculation Markus Pargmann
2015-12-04  7:09   ` Sascha Hauer
2015-12-02 13:48 ` [PATCH 7/9] arm: start: Add visible sdram region for barebox board data Markus Pargmann
2015-12-02 13:48 ` [PATCH 8/9] arm: Add RAMOOPS memory area Markus Pargmann
2015-12-04  7:07   ` Sascha Hauer
2015-12-04 13:30     ` Markus Pargmann
2015-12-07  9:15       ` Sascha Hauer
2015-12-02 13:48 ` [PATCH 9/9] fs: Add pstore filesystem Markus Pargmann
2015-12-02 18:37   ` Antony Pavlov
2015-12-04 13:10     ` Markus Pargmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151204071255.GS11966@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=mpa@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.