From: Tony Lindgren <tony@atomide.com>
To: Sudeep Holla <sudeep.holla@arm.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Grygorii Strashko <grygorii.strashko@ti.com>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
linux-omap@vger.kernel.org
Subject: Re: [PATCH 2/2] pinctrl: single: remove misuse of IRQF_NO_SUSPEND flag
Date: Fri, 4 Dec 2015 07:40:31 -0800 [thread overview]
Message-ID: <20151204154031.GG23396@atomide.com> (raw)
In-Reply-To: <20151203214013.GB23396@atomide.com>
* Tony Lindgren <tony@atomide.com> [151203 13:41]:
> * Sudeep Holla <sudeep.holla@arm.com> [151203 11:00]:
> >
> > I have added irq_set_irq_wake(pcs_soc->irq, state) in pcs_irq_set_wake
> > which ensures it's marked for wakeup.
>
> Hmm well see the error I pasted in this thread, maybe that provides
> more clues.
The irq_set_irq_wake(pcs_soc->irq, state) in pcs_irq_set_wake does not
look right to me as pcs_irq_set_wake toggles the irq_wake for each pin
separately, not for the whole controller.
I think all that can be left out with the snipped from Grygorii, and maybe
also the lock_class_key changes.
Regards,
Tony
next prev parent reply other threads:[~2015-12-04 15:40 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-27 17:20 [PATCH 1/2] pinctrl: single: Use a separate lockdep class Sudeep Holla
2015-11-27 17:21 ` [PATCH 2/2] pinctrl: single: remove misuse of IRQF_NO_SUSPEND flag Sudeep Holla
2015-12-01 14:06 ` Linus Walleij
2015-12-03 18:13 ` Tony Lindgren
2015-12-03 18:35 ` Grygorii Strashko
2015-12-03 18:35 ` Grygorii Strashko
2015-12-03 21:37 ` Tony Lindgren
2015-12-04 10:44 ` Grygorii Strashko
2015-12-04 10:44 ` Grygorii Strashko
2015-12-04 10:54 ` Sudeep Holla
2015-12-04 11:18 ` Grygorii Strashko
2015-12-04 11:18 ` Grygorii Strashko
2015-12-04 11:21 ` Sudeep Holla
2015-12-04 15:35 ` Tony Lindgren
2015-12-04 15:59 ` Grygorii Strashko
2015-12-04 15:59 ` Grygorii Strashko
2015-12-04 16:11 ` Sudeep Holla
2015-12-04 16:30 ` Grygorii Strashko
2015-12-04 16:30 ` Grygorii Strashko
2015-12-04 17:07 ` Tony Lindgren
2015-12-04 17:09 ` Tony Lindgren
2015-12-03 18:59 ` Sudeep Holla
2015-12-03 21:40 ` Tony Lindgren
2015-12-04 15:40 ` Tony Lindgren [this message]
2015-12-04 15:44 ` Sudeep Holla
2015-12-04 16:19 ` Grygorii Strashko
2015-12-04 16:19 ` Grygorii Strashko
2015-12-04 16:26 ` Sudeep Holla
2015-12-04 17:06 ` Tony Lindgren
2015-12-04 16:15 ` Sudeep Holla
2015-12-04 17:10 ` Tony Lindgren
2015-12-01 14:06 ` [PATCH 1/2] pinctrl: single: Use a separate lockdep class Linus Walleij
2015-12-01 14:09 ` Sudeep Holla
2015-12-03 18:07 ` Tony Lindgren
2015-12-03 21:46 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151204154031.GG23396@atomide.com \
--to=tony@atomide.com \
--cc=grygorii.strashko@ti.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=sudeep.holla@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.