From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Florian Westphal <fw@strlen.de>
Cc: netfilter-devel@vger.kernel.org, kaber@trash.net
Subject: Re: [PATCH nft 2/2] src: fix sub-bytes protocol header definition
Date: Fri, 4 Dec 2015 19:45:24 +0100 [thread overview]
Message-ID: <20151204184524.GA914@salvia> (raw)
In-Reply-To: <20151203002135.GA31167@breakpoint.cc>
On Thu, Dec 03, 2015 at 01:21:35AM +0100, Florian Westphal wrote:
> Pablo Neira Ayuso <pablo@netfilter.org> wrote:
> > This aims to fix what we have, I'm willing to give another pass to this.
>
> vlan type ip vlan id 4094 ip version 4 counter packets 567 bytes 37720
> vlan type ip vlan id 4094 vlan pcp 0 vlan cfi 0 counter packets 567 bytes 37720
> vlan type ip vlan id 4094 vlan pcp 1 vlan cfi 1 counter packets 0 bytes 0
> vlan type ip vlan id 4094 vlan pcp 1 vlan cfi 0 counter packets 0 bytes 0
> vlan type ip vlan id 4094 vlan pcp 0 vlan cfi 1 counter packets 0 bytes 0
>
> tpcdump says:
> 'length 194: vlan 4094, p 0, ethertype IPv4', i.e. this looks correct.
Thanks for testing.
I have a new patchset including this refined patch. It also includes
set matching for sub-byte fields. I have also used Patrick's idea of
using shifts through binop transfer. Will be submitting this tomorrow.
prev parent reply other threads:[~2015-12-04 18:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-01 17:44 [PATCH nft 1/2] tests: vlan pcp and cfi are located in the first byte Pablo Neira Ayuso
2015-12-01 17:44 ` [PATCH nft 2/2] src: fix sub-bytes protocol header definition Pablo Neira Ayuso
2015-12-03 0:21 ` Florian Westphal
2015-12-04 18:45 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151204184524.GA914@salvia \
--to=pablo@netfilter.org \
--cc=fw@strlen.de \
--cc=kaber@trash.net \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.