From: Kevin O'Connor <kevin@koconnor.net>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Patch Tracking <patches@linaro.org>,
Markus Armbruster <armbru@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>,
QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH 1/3] hw/sd/pxa2xx_mmci: convert to SysBusDevice object
Date: Fri, 4 Dec 2015 13:49:28 -0500 [thread overview]
Message-ID: <20151204184928.GA28805@morn.lan> (raw)
In-Reply-To: <CAFEAcA-9YGKGkkrK4wLk8Z48iTOruve1sX4AWu0FUF-ovmYoEg@mail.gmail.com>
On Fri, Dec 04, 2015 at 12:55:07PM +0000, Peter Maydell wrote:
> On 4 December 2015 at 12:50, Markus Armbruster <armbru@redhat.com> wrote:
> > To finally answer your question: the proper owner of the property
> > connecting the backend is the frontend half of the split device. So, if
> > we have separate device models for controller and the block devices
> > connected to it, the block backend property belongs to the latter, not
> > the former. If we have separate device models for SD controller and
> > card, the block backend property belongs to the card, not the
> > controller.
>
> I thought this might be your answer, but this is problematic because
> we now have a device in the tree (the sdhci pci card) which has the
> property on the controller, and so that's now user-facing command
> line ABI which we can't change...
If by ABI, you mean the command line format:
-device sdhci-pci,drive=drive0 -drive id=drive0,if=sd,file=myimage
then I don't see why that should change. As Paolo points out, there
is only one card per controller. That's how real hardware does it as
well.
Cheers,
-Kevin
next prev parent reply other threads:[~2015-12-04 18:49 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-11 14:15 [Qemu-devel] [PATCH 0/3] hw/sd/pxa2xx_mmci: convert to sysbus and vmstate Peter Maydell
2015-08-11 14:15 ` [Qemu-devel] [PATCH 1/3] hw/sd/pxa2xx_mmci: convert to SysBusDevice object Peter Maydell
2015-09-07 16:40 ` Markus Armbruster
2015-09-07 16:42 ` Peter Maydell
2015-09-07 16:57 ` Markus Armbruster
2015-12-03 21:20 ` Peter Maydell
2015-12-04 7:30 ` Markus Armbruster
2015-12-04 11:00 ` Peter Maydell
2015-12-04 12:50 ` Markus Armbruster
2015-12-04 12:55 ` Peter Maydell
2015-12-04 13:04 ` Markus Armbruster
2015-12-04 18:49 ` Kevin O'Connor [this message]
2015-12-04 16:42 ` Paolo Bonzini
2015-12-04 18:50 ` Peter Crosthwaite
2015-12-04 19:24 ` Kevin O'Connor
2015-12-07 0:02 ` Peter Crosthwaite
2015-12-07 6:11 ` Kevin O'Connor
2015-12-07 8:50 ` Markus Armbruster
2015-12-07 9:58 ` Paolo Bonzini
2015-12-07 10:31 ` Markus Armbruster
2015-12-07 14:32 ` Peter Maydell
2015-09-07 18:39 ` Peter Crosthwaite
2015-08-11 14:15 ` [Qemu-devel] [PATCH 2/3] hw/sd/pxa2xx_mmci: Convert to VMStateDescription Peter Maydell
2015-08-11 14:15 ` [Qemu-devel] [PATCH 3/3] hw/sd/pxa2xx_mmci: Add reset function Peter Maydell
2015-09-07 15:34 ` [Qemu-devel] [PATCH 0/3] hw/sd/pxa2xx_mmci: convert to sysbus and vmstate Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151204184928.GA28805@morn.lan \
--to=kevin@koconnor.net \
--cc=armbru@redhat.com \
--cc=patches@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.