From: Wolfram Sang <wsa@the-dreams.de>
To: Gao Pan <b54642@freescale.com>
Cc: u.kleine-koenig@pengutronix.de, linux-i2c@vger.kernel.org,
B20596@freescale.com, b38611@freescale.com,
kernel@pengutronix.de
Subject: Re: [Patch V1] i2c: imx: init bus recovery info before adding i2c adapter
Date: Sat, 5 Dec 2015 20:07:36 +0100 [thread overview]
Message-ID: <20151205190736.GD1597@katana> (raw)
In-Reply-To: <1449221594-29603-1-git-send-email-b54642@freescale.com>
[-- Attachment #1: Type: text/plain, Size: 782 bytes --]
On Fri, Dec 04, 2015 at 05:33:14PM +0800, Gao Pan wrote:
> During driver probe, i2c_imx_init_recovery_info() must come before
> i2c_add_numbered_adapter(), because the get/set_scl() functions
> are assigned in i2c_register_adapter() under the conditon that bus
> recover_info are initialized. Otherwise, get/set_scl() function
> pointers never get assigned.
>
> In such case, when i2c_generic_gpio_recovery() is used for bus recovery,
> there will be kernel crash because bri->set_scl is NULL.
>
> The solution to this bug is moving i2c_imx_init_recovery_info() before
> i2c_register_adapter().
>
> Signed-off-by: Gao Pan <b54642@freescale.com>
> Signed-off-by: Fugang Duan <B38611@freescale.com>
Makes sense, but I can't apply this one. What is it based on?
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2015-12-05 19:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-04 9:33 [Patch V1] i2c: imx: init bus recovery info before adding i2c adapter Gao Pan
2015-12-05 19:07 ` Wolfram Sang [this message]
2015-12-07 2:45 ` Gao Pandy
2015-12-09 10:18 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151205190736.GD1597@katana \
--to=wsa@the-dreams.de \
--cc=B20596@freescale.com \
--cc=b38611@freescale.com \
--cc=b54642@freescale.com \
--cc=kernel@pengutronix.de \
--cc=linux-i2c@vger.kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.