From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tom Rini Date: Sun, 6 Dec 2015 17:07:52 -0500 Subject: [U-Boot] [U-Boot, v3, 3/3] spl: mmc: Unify non/driver model spl_mmc_find_device() In-Reply-To: <1449079153-25422-4-git-send-email-sjg@chromium.org> References: <1449079153-25422-4-git-send-email-sjg@chromium.org> Message-ID: <20151206220752.GX9551@bill-the-cat> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Wed, Dec 02, 2015 at 10:59:13AM -0700, Simon Glass wrote: > It is risky to have two different functions with much the same code. Future > authors may update one but not the other. It is hard to see which parts are > the same and which are different. > > Unify the functions and drop the differences that are not really needed. > > Note that one puts() becomes printf() as Tom mentioned that this does not > affect image size: > > https://patchwork.ozlabs.org/patch/537276/ > > Note: It would be better to have an empty printf() and avoid the #ifdef for > CONFIG_SPL_LIBCOMMON_SUPPORT. > > Signed-off-by: Simon Glass > Tested-by: Michal Simek Applied to u-boot/master, thanks! -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 836 bytes Desc: Digital signature URL: