From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jason Gunthorpe Subject: Re: [PATCH for-next V2 05/11] IB/core: Add rdma_network_type to wc Date: Sun, 6 Dec 2015 23:02:41 -0700 Message-ID: <20151207060241.GA19038@obsidianresearch.com> References: <1449150450-13679-1-git-send-email-matanb@mellanox.com> <1449150450-13679-6-git-send-email-matanb@mellanox.com> <20151203140543.GA4283@infradead.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Liran Liss Cc: Christoph Hellwig , Matan Barak , Doug Ledford , "linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Eran Ben Elisha , Haggai Eran , Or Gerlitz , Somnath Kotur List-Id: linux-rdma@vger.kernel.org On Thu, Dec 03, 2015 at 04:20:50PM +0000, Liran Liss wrote: > > From: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org [mailto:linux-rdma- > > > Subject: Re: [PATCH for-next V2 05/11] IB/core: Add rdma_network_type to > > wc > > > > Bloating the WC with a field that's not really useful for the ULPs seems pretty > > sad.. > > You need per packet (read per-WC) network type both for handling incoming connections over QP1 and in UD QPs. > It looks like this patch doesn't extend the structure size due to alignment, so no real harm in any case... Why? The sgid index must tell you the network type. Jason -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html