From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Christophe Ricard <christophe.ricard@gmail.com>
Cc: rjw@rjwysocki.net, Len Brown <lenb@kernel.org>,
Linus Walleij <linus.walleij@linaro.org>,
Alexandre Courbot <gnurou@gmail.com>,
andriy.shevchenko@linux.intel.com, linux-i2c@vger.kernel.org,
linux-gpio@vger.kernel.org, linux-acpi@vger.kernel.org,
Christophe Ricard <christophe-h.ricard@st.com>
Subject: Re: [PATCH v3 0/2] ACPI: Add irq_type to gpio interrupt
Date: Mon, 7 Dec 2015 12:52:21 +0200 [thread overview]
Message-ID: <20151207105221.GI16813@lahna.fi.intel.com> (raw)
In-Reply-To: <56622373.7020406@gmail.com>
On Sat, Dec 05, 2015 at 12:36:19AM +0100, Christophe Ricard wrote:
> >No, but I wonder if it would be better to do this in acpi_dev_gpio_irq_get()
> >instead of acpi_find_gpio() which gets called everytime a GPIO is looked up?
> I believe, setting the irq type requires triggering and polarity data stored
> into a struct acpi_resource_gpio.
>
> acpi_dev_gpio_irq_get call acpi_get_gpiod_by_index which run acpi_find_gpio.
>
> Actually acpi_dev_gpio_irq_get is called everytime an i2c device slave is
> probed, acpi_find_gpio will get called to "register" gpios.
> If done correctly, i think this will be done only once...
>
> The only improvement i may see would be to add an extra field in the
> acpi_gpio_info structure in drivers/gpio/gpiolib.h (for example int
> irq_type).
> And call irq_set_irq_type in acpi_dev_gpio_irq_get if the gpio is an
> interrupt.
>
> I guess the current proposal and this one are equivalent...
>
> What do you think ?
Actually I think it may be useful to add triggering flags to
acpi_gpio_info.
next prev parent reply other threads:[~2015-12-07 10:52 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-30 22:47 [PATCH v3 0/2] ACPI: Add irq_type to gpio interrupt Christophe Ricard
2015-11-30 22:47 ` [PATCH v3 1/2] acpi: Rename acpi_gsi_get_irq_type to acpi_get_irq_type and export symbol Christophe Ricard
2015-11-30 22:47 ` [PATCH v3 2/2] ACPI / gpio: Add irq_type when a gpio is used as an interrupt Christophe Ricard
2015-12-10 17:00 ` Linus Walleij
2015-12-01 1:03 ` [PATCH v3 0/2] ACPI: Add irq_type to gpio interrupt Wolfram Sang
2015-12-01 7:03 ` Christophe Ricard
2015-12-01 11:21 ` Mika Westerberg
[not found] ` <CALD+uuxJw5tQ2XY99nHigXdNkcXGnng+r9NZ8H9TqUF9GbgW=A@mail.gmail.com>
2015-12-01 13:03 ` Mika Westerberg
2015-12-04 23:36 ` Christophe Ricard
2015-12-07 10:52 ` Mika Westerberg [this message]
2015-12-07 10:53 ` Christophe Henri RICARD
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151207105221.GI16813@lahna.fi.intel.com \
--to=mika.westerberg@linux.intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=christophe-h.ricard@st.com \
--cc=christophe.ricard@gmail.com \
--cc=gnurou@gmail.com \
--cc=lenb@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.