From mboxrd@z Thu Jan 1 00:00:00 1970 From: Konrad Rzeszutek Wilk Subject: Re: [PATCH] xen-blkback: clear PF_NOFREEZE for xen_blkif_schedule() Date: Mon, 7 Dec 2015 17:00:22 -0500 Message-ID: <20151207220022.GA6958@char.us.oracle.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1a63pg-00021s-5j for xen-devel@lists.xenproject.org; Mon, 07 Dec 2015 22:00:32 +0000 Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jiri Kosina Cc: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, roger.pau@citrix.com List-Id: xen-devel@lists.xenproject.org On Mon, Oct 26, 2015 at 02:47:21PM +0900, Jiri Kosina wrote: > From: Jiri Kosina > > xen_blkif_schedule() kthread calls try_to_freeze() at the beginning of > every attempt to purge the LRU. This operation can't ever succeed though, > as the kthread hasn't marked itself as freezable. ! > > Before (hopefully eventually) kthread freezing gets converted to fileystem > freezing, we'd rather mark xen_blkif_schedule() freezable (as it can > generate I/O during suspend). > > Signed-off-by: Jiri Kosina Thank you for reporting that. Will queue it up for Linux 4.5! > --- > drivers/block/xen-blkback/blkback.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/block/xen-blkback/blkback.c b/drivers/block/xen-blkback/blkback.c > index af3caa3..bb65f7c 100644 > --- a/drivers/block/xen-blkback/blkback.c > +++ b/drivers/block/xen-blkback/blkback.c > @@ -597,6 +597,7 @@ int xen_blkif_schedule(void *arg) > > xen_blkif_get(blkif); > > + set_freezable(); > while (!kthread_should_stop()) { > if (unlikely(vbd->size != vbd_sz(vbd))) > xen_vbd_resize(blkif); > > -- > Jiri Kosina > SUSE Labs