All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen@networkplumber.org>
To: dev@dpdk.org
Subject: New Coverity warnings
Date: Tue, 8 Dec 2015 08:50:04 -0800	[thread overview]
Message-ID: <20151208085004.2d4440f5@xeon-e3> (raw)

*** CID 120410:  Error handling issues  (CHECKED_RETURN)
/examples/l2fwd-keepalive/main.c: 571 in dead_core()
565     
566     static void
567     dead_core(__attribute__((unused)) void *ptr_data, const int id_core)
568     {
569     	printf("Dead core %i - restarting..\n", id_core);
570     	if (rte_eal_get_lcore_state(id_core) == FINISHED) {
>>>     CID 120410:  Error handling issues  (CHECKED_RETURN)
>>>     Calling "rte_eal_wait_lcore" without checking return value (as is done elsewhere 32 out of 40 times).  
571     		rte_eal_wait_lcore(id_core);
572     		rte_eal_remote_launch(l2fwd_launch_one_lcore, NULL, id_core);
573     	} else {
574     		printf("..false positive!\n");
575     	}
576     }

** CID 37790:  Error handling issues  (CHECKED_RETURN)
/examples/bond/main.c: 593 in cmd_stop_parsed()


________________________________________________________________________________________________________
*** CID 37790:  Error handling issues  (CHECKED_RETURN)
/examples/bond/main.c: 593 in cmd_stop_parsed()
587     					"lcore_main not running on core:%d\n",
588     					global_flag_stru_p->LcoreMainCore);
589     		rte_spinlock_unlock(&global_flag_stru_p->lock);
590     		return;
591     	}
592     	global_flag_stru_p->LcoreMainIsRunning = 0;
>>>     CID 37790:  Error handling issues  (CHECKED_RETURN)
>>>     Calling "rte_eal_wait_lcore" without checking return value (as is done elsewhere 32 out of 40 times).  
593     	rte_eal_wait_lcore(global_flag_stru_p->LcoreMainCore);
594     	cmdline_printf(cl,
595     			"lcore_main stopped on core:%d\n",
596     			global_flag_stru_p->LcoreMainCore);
597     	rte_spinlock_unlock(&global_flag_stru_p->lock);
598     }

** CID 37789:  Error handling issues  (CHECKED_RETURN)
/examples/bond/main.c: 631 in cmd_quit_parsed()


________________________________________________________________________________________________________
*** CID 37789:  Error handling issues  (CHECKED_RETURN)
/examples/bond/main.c: 631 in cmd_quit_parsed()
625     					global_flag_stru_p->LcoreMainCore);
626     		rte_spinlock_unlock(&global_flag_stru_p->lock);
627     		cmdline_quit(cl);
628     		return;
629     	}
630     	global_flag_stru_p->LcoreMainIsRunning = 0;
>>>     CID 37789:  Error handling issues  (CHECKED_RETURN)
>>>     Calling "rte_eal_wait_lcore" without checking return value (as is done elsewhere 32 out of 40 times).  
631     	rte_eal_wait_lcore(global_flag_stru_p->LcoreMainCore);
632     	cmdline_printf(cl,
633     			"lcore_main stopped on core:%d\n",
634     			global_flag_stru_p->LcoreMainCore);
635     	rte_spinlock_unlock(&global_flag_stru_p->lock);
636     	cmdline_quit(cl);

             reply	other threads:[~2015-12-08 16:49 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-08 16:50 Stephen Hemminger [this message]
2015-12-08 17:19 ` New Coverity warnings Mcnamara, John

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151208085004.2d4440f5@xeon-e3 \
    --to=stephen@networkplumber.org \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.