diff for duplicates of <20151208091451.4eef0b50@bbrezillon> diff --git a/a/1.txt b/N1/1.txt index b8e21fc..5d89008 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,7 +1,7 @@ Hi Priit, On Tue, 08 Dec 2015 08:43:05 +0200 -Priit Laes <plaes@plaes.org> wrote: +Priit Laes <plaes-q/aMd4JkU83YtjvyW6yDsg@public.gmane.org> wrote: > On Mon, 2015-12-07 at 23:25 +0100, Boris Brezillon wrote: > > ecclayout->oobavail is just redundant with the mtd->oobavail field. @@ -11,7 +11,7 @@ Priit Laes <plaes@plaes.org> wrote: > > >oobfree > > field. > > -> > Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com> +> > Signed-off-by: Boris Brezillon <boris.brezillon-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> > > --- > > drivers/mtd/devices/docg3.c | 5 ++- > > drivers/mtd/mtdswap.c | 16 ++++----- @@ -148,3 +148,8 @@ Boris Boris Brezillon, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com + +-- +You received this message because you are subscribed to the Google Groups "linux-sunxi" group. +To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org +For more options, visit https://groups.google.com/d/optout. diff --git a/a/content_digest b/N1/content_digest index 25fc512..1e729db 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,39 +1,40 @@ "ref\01449527178-5930-1-git-send-email-boris.brezillon@free-electrons.com\0" "ref\01449527178-5930-2-git-send-email-boris.brezillon@free-electrons.com\0" "ref\01449556985.25438.8.camel@plaes.org\0" - "From\0Boris Brezillon <boris.brezillon@free-electrons.com>\0" - "Subject\0Re: [linux-sunxi] [PATCH 01/23] mtd: kill the ecclayout->oobavail field\0" + "ref\01449556985.25438.8.camel-q/aMd4JkU83YtjvyW6yDsg@public.gmane.org\0" + "From\0Boris Brezillon <boris.brezillon-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>\0" + "Subject\0Re: [PATCH 01/23] mtd: kill the ecclayout->oobavail field\0" "Date\0Tue, 8 Dec 2015 09:14:51 +0100\0" - "To\0Priit Laes <plaes@plaes.org>\0" - "Cc\0David Woodhouse <dwmw2@infradead.org>" - Brian Norris <computersforpeace@gmail.com> - linux-mtd@lists.infradead.org - Daniel Mack <daniel@zonque.org> - Haojian Zhuang <haojian.zhuang@gmail.com> - Robert Jarzmik <robert.jarzmik@free.fr> - Kukjin Kim <kgene@kernel.org> - Krzysztof Kozlowski <k.kozlowski@samsung.com> - linux-samsung-soc@vger.kernel.org - linux-arm-kernel@lists.infradead.org - Ralf Baechle <ralf@linux-mips.org> - linux-mips@linux-mips.org - Josh Wu <josh.wu@atmel.com> - Ezequiel Garcia <ezequiel.garcia@free-electrons.com> - Maxime Ripard <maxime.ripard@free-electrons.com> - Chen-Yu Tsai <wens@csie.org> - linux-sunxi@googlegroups.com - Stefan Agner <stefan@agner.ch> - Kyungmin Park <kyungmin.park@samsung.com> - Greg Kroah-Hartman <gregkh@linuxfoundation.org> - devel@driverdev.osuosl.org - linux-kernel@vger.kernel.org - " punnaiah choudary kalluri <punnaia@xilinx.com>\0" + "To\0Priit Laes <plaes-q/aMd4JkU83YtjvyW6yDsg@public.gmane.org>\0" + "Cc\0David Woodhouse <dwmw2-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>" + Brian Norris <computersforpeace-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> + linux-mtd-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org + Daniel Mack <daniel-cYrQPVfZoowdnm+yROfE0A@public.gmane.org> + Haojian Zhuang <haojian.zhuang-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> + Robert Jarzmik <robert.jarzmik-GANU6spQydw@public.gmane.org> + Kukjin Kim <kgene-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> + Krzysztof Kozlowski <k.kozlowski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> + linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org + linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org + Ralf Baechle <ralf-6z/3iImG2C8G8FEW9MqTrA@public.gmane.org> + linux-mips-6z/3iImG2C8G8FEW9MqTrA@public.gmane.org + Josh Wu <josh.wu-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org> + Ezequiel Garcia <ezequiel.garcia-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> + Maxime Ripard <maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> + Chen-Yu Tsai <wens-jdAy2FN1RRM@public.gmane.org> + linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org + Stefan Agner <stefan-XLVq0VzYD2Y@public.gmane.org> + Kyungmin Park <kyungmin.park-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> + Greg Kroah-Hartman <gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org> + devel-gWbeCf7V1WCQmaza687I9mD2FQJk+8+b@public.gmane.org + linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org + " punnaiah choudary kalluri <punnaia-gjFFaj9aHVfQT0dZR+AlfA@public.gmane.org>\0" "\00:1\0" "b\0" "Hi Priit,\n" "\n" "On Tue, 08 Dec 2015 08:43:05 +0200\n" - "Priit Laes <plaes@plaes.org> wrote:\n" + "Priit Laes <plaes-q/aMd4JkU83YtjvyW6yDsg@public.gmane.org> wrote:\n" "\n" "> On Mon, 2015-12-07 at 23:25 +0100, Boris Brezillon wrote:\n" "> > ecclayout->oobavail is just redundant with the mtd->oobavail field.\n" @@ -43,7 +44,7 @@ "> > >oobfree\n" "> > field.\n" "> > \n" - "> > Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>\n" + "> > Signed-off-by: Boris Brezillon <boris.brezillon-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>\n" "> > ---\n" "> > \302\240drivers/mtd/devices/docg3.c\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240|\302\240\302\2405 ++-\n" "> > \302\240drivers/mtd/mtdswap.c\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240| 16 ++++-----\n" @@ -179,6 +180,11 @@ "-- \n" "Boris Brezillon, Free Electrons\n" "Embedded Linux and Kernel engineering\n" - http://free-electrons.com + "http://free-electrons.com\n" + "\n" + "-- \n" + "You received this message because you are subscribed to the Google Groups \"linux-sunxi\" group.\n" + "To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org\n" + For more options, visit https://groups.google.com/d/optout. -c973f5a39e6e96ce6c1899c519f4799c64b1ab6d03aeeea27bcfbac3eda848e0 +f475109c08e2ce83d0d3ed3d9febda0e430a9d52390c73e4ae73d41a302620e7
diff --git a/a/1.txt b/N2/1.txt index b8e21fc..ea8e492 100644 --- a/a/1.txt +++ b/N2/1.txt @@ -13,36 +13,36 @@ Priit Laes <plaes@plaes.org> wrote: > > > > Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com> > > --- -> > drivers/mtd/devices/docg3.c | 5 ++- -> > drivers/mtd/mtdswap.c | 16 ++++----- -> > drivers/mtd/nand/brcmnand/brcmnand.c | 3 -- -> > drivers/mtd/nand/docg4.c | 1 - -> > drivers/mtd/nand/hisi504_nand.c | 1 - -> > drivers/mtd/nand/nand_base.c | 12 +++---- -> > drivers/mtd/onenand/onenand_base.c | 16 ++++----- -> > drivers/mtd/tests/oobtest.c | 49 +++++++++++++-- +> > ?drivers/mtd/devices/docg3.c???????????????????|??5 ++- +> > ?drivers/mtd/mtdswap.c?????????????????????????| 16 ++++----- +> > ?drivers/mtd/nand/brcmnand/brcmnand.c??????????|??3 -- +> > ?drivers/mtd/nand/docg4.c??????????????????????|??1 - +> > ?drivers/mtd/nand/hisi504_nand.c???????????????|??1 - +> > ?drivers/mtd/nand/nand_base.c??????????????????| 12 +++---- +> > ?drivers/mtd/onenand/onenand_base.c????????????| 16 ++++----- +> > ?drivers/mtd/tests/oobtest.c???????????????????| 49 +++++++++++++-- > > ------------ -> > drivers/staging/mt29f_spinand/mt29f_spinand.c | 1 - -> > fs/jffs2/wbuf.c | 6 ++-- -> > include/linux/mtd/mtd.h | 1 - -> > 11 files changed, 48 insertions(+), 63 deletions(-) +> > ?drivers/staging/mt29f_spinand/mt29f_spinand.c |??1 - +> > ?fs/jffs2/wbuf.c???????????????????????????????|??6 ++-- +> > ?include/linux/mtd/mtd.h???????????????????????|??1 - +> > ?11 files changed, 48 insertions(+), 63 deletions(-) > > > [..] -> > +> > ? > > diff --git a/drivers/mtd/nand/brcmnand/brcmnand.c > > b/drivers/mtd/nand/brcmnand/brcmnand.c > > index 35d78f7..a906ec2 100644 > > --- a/drivers/mtd/nand/brcmnand/brcmnand.c > > +++ b/drivers/mtd/nand/brcmnand/brcmnand.c > > @@ -845,9 +845,6 @@ static struct nand_ecclayout *brcmnand_create_layout(int ecc_level, -> > break; -> > } -> > out: +> > ? break; +> > ? } +> > ?out: > > - /* Sum available OOB */ > > - for (i = 0; i < MTD_MAX_OOBFREE_ENTRIES_LARGE; i++) > > - layout->oobavail += layout->oobfree[i].length; -> > return layout; -> > } +> > ? return layout; +> > ?} > > You can get rid of the 'out' label and replace the single goto in this > function with 'return layout'. @@ -51,7 +51,7 @@ Yep, I'll fix that. > > [...] -> > +> > ? > > diff --git a/drivers/mtd/nand/nand_base.c > > b/drivers/mtd/nand/nand_base.c > > index 0748a13..1107f5c1 100644 @@ -59,25 +59,25 @@ Yep, I'll fix that. > > +++ b/drivers/mtd/nand/nand_base.c > > @@ -2037,7 +2037,7 @@ static int nand_do_read_oob(struct mtd_info > > *mtd, loff_t from, -> > stats = mtd->ecc_stats; -> > -> > if (ops->mode == MTD_OPS_AUTO_OOB) +> > ? stats = mtd->ecc_stats; +> > ? +> > ? if (ops->mode == MTD_OPS_AUTO_OOB) > > - len = chip->ecc.layout->oobavail; > > + len = mtd->oobavail; -> > else -> > len = mtd->oobsize; -> > +> > ? else +> > ? len = mtd->oobsize; +> > ? > > @@ -2728,7 +2728,7 @@ static int nand_do_write_oob(struct mtd_info > > *mtd, loff_t to, -> > __func__, (unsigned int)to, (int)ops- +> > ? ?__func__, (unsigned int)to, (int)ops- > > >ooblen); -> > -> > if (ops->mode == MTD_OPS_AUTO_OOB) +> > ? +> > ? if (ops->mode == MTD_OPS_AUTO_OOB) > > - len = chip->ecc.layout->oobavail; > > + len = mtd->oobavail; -> > else -> > len = mtd->oobsize; -> > +> > ? else +> > ? len = mtd->oobsize; +> > ? > [...] > > diff --git a/drivers/mtd/onenand/onenand_base.c > > b/drivers/mtd/onenand/onenand_base.c @@ -86,53 +86,53 @@ Yep, I'll fix that. > > +++ b/drivers/mtd/onenand/onenand_base.c > > @@ -1125,7 +1125,7 @@ static int onenand_mlc_read_ops_nolock(struct > > mtd_info *mtd, loff_t from, -> > (int)len); -> > -> > if (ops->mode == MTD_OPS_AUTO_OOB) +> > ? (int)len); +> > ? +> > ? if (ops->mode == MTD_OPS_AUTO_OOB) > > - oobsize = this->ecclayout->oobavail; > > + oobsize = mtd->oobavail; -> > else -> > oobsize = mtd->oobsize; -> > +> > ? else +> > ? oobsize = mtd->oobsize; +> > ? > > @@ -1230,7 +1230,7 @@ static int onenand_read_ops_nolock(struct > > mtd_info *mtd, loff_t from, -> > (int)len); -> > -> > if (ops->mode == MTD_OPS_AUTO_OOB) +> > ? (int)len); +> > ? +> > ? if (ops->mode == MTD_OPS_AUTO_OOB) > > - oobsize = this->ecclayout->oobavail; > > + oobsize = mtd->oobavail; -> > else -> > oobsize = mtd->oobsize; -> > +> > ? else +> > ? oobsize = mtd->oobsize; +> > ? > > @@ -1365,7 +1365,7 @@ static int onenand_read_oob_nolock(struct > > mtd_info *mtd, loff_t from, -> > ops->oobretlen = 0; -> > -> > if (mode == MTD_OPS_AUTO_OOB) +> > ? ops->oobretlen = 0; +> > ? +> > ? if (mode == MTD_OPS_AUTO_OOB) > > - oobsize = this->ecclayout->oobavail; > > + oobsize = mtd->oobavail; -> > else -> > oobsize = mtd->oobsize; -> > +> > ? else +> > ? oobsize = mtd->oobsize; +> > ? > > @@ -1887,7 +1887,7 @@ static int onenand_write_ops_nolock(struct > > mtd_info *mtd, loff_t to, -> > return 0; -> > -> > if (ops->mode == MTD_OPS_AUTO_OOB) +> > ? return 0; +> > ? +> > ? if (ops->mode == MTD_OPS_AUTO_OOB) > > - oobsize = this->ecclayout->oobavail; > > + oobsize = mtd->oobavail; -> > else -> > oobsize = mtd->oobsize; -> > +> > ? else +> > ? oobsize = mtd->oobsize; +> > ? > > @@ -2063,7 +2063,7 @@ static int onenand_write_oob_nolock(struct > > mtd_info *mtd, loff_t to, -> > ops->oobretlen = 0; -> > -> > if (mode == MTD_OPS_AUTO_OOB) +> > ? ops->oobretlen = 0; +> > ? +> > ? if (mode == MTD_OPS_AUTO_OOB) > > - oobsize = this->ecclayout->oobavail; > > + oobsize = mtd->oobavail; -> > else -> > oobsize = mtd->oobsize; +> > ? else +> > ? oobsize = mtd->oobsize; > > This identical construction seems to occur multiple times in multiple > files. Would it make sense to create a macro for it? diff --git a/a/content_digest b/N2/content_digest index 25fc512..49d46d9 100644 --- a/a/content_digest +++ b/N2/content_digest @@ -1,33 +1,10 @@ "ref\01449527178-5930-1-git-send-email-boris.brezillon@free-electrons.com\0" "ref\01449527178-5930-2-git-send-email-boris.brezillon@free-electrons.com\0" "ref\01449556985.25438.8.camel@plaes.org\0" - "From\0Boris Brezillon <boris.brezillon@free-electrons.com>\0" - "Subject\0Re: [linux-sunxi] [PATCH 01/23] mtd: kill the ecclayout->oobavail field\0" + "From\0boris.brezillon@free-electrons.com (Boris Brezillon)\0" + "Subject\0[linux-sunxi] [PATCH 01/23] mtd: kill the ecclayout->oobavail field\0" "Date\0Tue, 8 Dec 2015 09:14:51 +0100\0" - "To\0Priit Laes <plaes@plaes.org>\0" - "Cc\0David Woodhouse <dwmw2@infradead.org>" - Brian Norris <computersforpeace@gmail.com> - linux-mtd@lists.infradead.org - Daniel Mack <daniel@zonque.org> - Haojian Zhuang <haojian.zhuang@gmail.com> - Robert Jarzmik <robert.jarzmik@free.fr> - Kukjin Kim <kgene@kernel.org> - Krzysztof Kozlowski <k.kozlowski@samsung.com> - linux-samsung-soc@vger.kernel.org - linux-arm-kernel@lists.infradead.org - Ralf Baechle <ralf@linux-mips.org> - linux-mips@linux-mips.org - Josh Wu <josh.wu@atmel.com> - Ezequiel Garcia <ezequiel.garcia@free-electrons.com> - Maxime Ripard <maxime.ripard@free-electrons.com> - Chen-Yu Tsai <wens@csie.org> - linux-sunxi@googlegroups.com - Stefan Agner <stefan@agner.ch> - Kyungmin Park <kyungmin.park@samsung.com> - Greg Kroah-Hartman <gregkh@linuxfoundation.org> - devel@driverdev.osuosl.org - linux-kernel@vger.kernel.org - " punnaiah choudary kalluri <punnaia@xilinx.com>\0" + "To\0linux-arm-kernel@lists.infradead.org\0" "\00:1\0" "b\0" "Hi Priit,\n" @@ -45,36 +22,36 @@ "> > \n" "> > Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>\n" "> > ---\n" - "> > \302\240drivers/mtd/devices/docg3.c\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240|\302\240\302\2405 ++-\n" - "> > \302\240drivers/mtd/mtdswap.c\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240| 16 ++++-----\n" - "> > \302\240drivers/mtd/nand/brcmnand/brcmnand.c\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240|\302\240\302\2403 --\n" - "> > \302\240drivers/mtd/nand/docg4.c\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240|\302\240\302\2401 -\n" - "> > \302\240drivers/mtd/nand/hisi504_nand.c\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240|\302\240\302\2401 -\n" - "> > \302\240drivers/mtd/nand/nand_base.c\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240| 12 +++----\n" - "> > \302\240drivers/mtd/onenand/onenand_base.c\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240| 16 ++++-----\n" - "> > \302\240drivers/mtd/tests/oobtest.c\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240| 49 +++++++++++++--\n" + "> > ?drivers/mtd/devices/docg3.c???????????????????|??5 ++-\n" + "> > ?drivers/mtd/mtdswap.c?????????????????????????| 16 ++++-----\n" + "> > ?drivers/mtd/nand/brcmnand/brcmnand.c??????????|??3 --\n" + "> > ?drivers/mtd/nand/docg4.c??????????????????????|??1 -\n" + "> > ?drivers/mtd/nand/hisi504_nand.c???????????????|??1 -\n" + "> > ?drivers/mtd/nand/nand_base.c??????????????????| 12 +++----\n" + "> > ?drivers/mtd/onenand/onenand_base.c????????????| 16 ++++-----\n" + "> > ?drivers/mtd/tests/oobtest.c???????????????????| 49 +++++++++++++--\n" "> > ------------\n" - "> > \302\240drivers/staging/mt29f_spinand/mt29f_spinand.c |\302\240\302\2401 -\n" - "> > \302\240fs/jffs2/wbuf.c\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240|\302\240\302\2406 ++--\n" - "> > \302\240include/linux/mtd/mtd.h\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240|\302\240\302\2401 -\n" - "> > \302\24011 files changed, 48 insertions(+), 63 deletions(-)\n" + "> > ?drivers/staging/mt29f_spinand/mt29f_spinand.c |??1 -\n" + "> > ?fs/jffs2/wbuf.c???????????????????????????????|??6 ++--\n" + "> > ?include/linux/mtd/mtd.h???????????????????????|??1 -\n" + "> > ?11 files changed, 48 insertions(+), 63 deletions(-)\n" "> > \n" "> [..]\n" - "> > \302\240\n" + "> > ?\n" "> > diff --git a/drivers/mtd/nand/brcmnand/brcmnand.c\n" "> > b/drivers/mtd/nand/brcmnand/brcmnand.c\n" "> > index 35d78f7..a906ec2 100644\n" "> > --- a/drivers/mtd/nand/brcmnand/brcmnand.c\n" "> > +++ b/drivers/mtd/nand/brcmnand/brcmnand.c\n" "> > @@ -845,9 +845,6 @@ static struct nand_ecclayout *brcmnand_create_layout(int ecc_level,\n" - "> > \302\240\t\t\tbreak;\n" - "> > \302\240\t}\n" - "> > \302\240out:\n" + "> > ?\t\t\tbreak;\n" + "> > ?\t}\n" + "> > ?out:\n" "> > -\t/* Sum available OOB */\n" "> > -\tfor (i = 0; i < MTD_MAX_OOBFREE_ENTRIES_LARGE; i++)\n" "> > -\t\tlayout->oobavail += layout->oobfree[i].length;\n" - "> > \302\240\treturn layout;\n" - "> > \302\240}\n" + "> > ?\treturn layout;\n" + "> > ?}\n" "> \n" "> You can get rid of the 'out' label and replace the single goto in this\n" "> function with 'return layout'.\n" @@ -83,7 +60,7 @@ "\n" "> \n" "> [...]\n" - "> > \302\240\n" + "> > ?\n" "> > diff --git a/drivers/mtd/nand/nand_base.c\n" "> > b/drivers/mtd/nand/nand_base.c\n" "> > index 0748a13..1107f5c1 100644\n" @@ -91,25 +68,25 @@ "> > +++ b/drivers/mtd/nand/nand_base.c\n" "> > @@ -2037,7 +2037,7 @@ static int nand_do_read_oob(struct mtd_info\n" "> > *mtd, loff_t from,\n" - "> > \302\240\tstats = mtd->ecc_stats;\n" - "> > \302\240\n" - "> > \302\240\tif (ops->mode == MTD_OPS_AUTO_OOB)\n" + "> > ?\tstats = mtd->ecc_stats;\n" + "> > ?\n" + "> > ?\tif (ops->mode == MTD_OPS_AUTO_OOB)\n" "> > -\t\tlen = chip->ecc.layout->oobavail;\n" "> > +\t\tlen = mtd->oobavail;\n" - "> > \302\240\telse\n" - "> > \302\240\t\tlen = mtd->oobsize;\n" - "> > \302\240\n" + "> > ?\telse\n" + "> > ?\t\tlen = mtd->oobsize;\n" + "> > ?\n" "> > @@ -2728,7 +2728,7 @@ static int nand_do_write_oob(struct mtd_info\n" "> > *mtd, loff_t to,\n" - "> > \302\240\t\t\t\302\240__func__, (unsigned int)to, (int)ops-\n" + "> > ?\t\t\t?__func__, (unsigned int)to, (int)ops-\n" "> > >ooblen);\n" - "> > \302\240\n" - "> > \302\240\tif (ops->mode == MTD_OPS_AUTO_OOB)\n" + "> > ?\n" + "> > ?\tif (ops->mode == MTD_OPS_AUTO_OOB)\n" "> > -\t\tlen = chip->ecc.layout->oobavail;\n" "> > +\t\tlen = mtd->oobavail;\n" - "> > \302\240\telse\n" - "> > \302\240\t\tlen = mtd->oobsize;\n" - "> > \302\240\n" + "> > ?\telse\n" + "> > ?\t\tlen = mtd->oobsize;\n" + "> > ?\n" "> [...]\n" "> > diff --git a/drivers/mtd/onenand/onenand_base.c\n" "> > b/drivers/mtd/onenand/onenand_base.c\n" @@ -118,53 +95,53 @@ "> > +++ b/drivers/mtd/onenand/onenand_base.c\n" "> > @@ -1125,7 +1125,7 @@ static int onenand_mlc_read_ops_nolock(struct\n" "> > mtd_info *mtd, loff_t from,\n" - "> > \302\240\t\t\t(int)len);\n" - "> > \302\240\n" - "> > \302\240\tif (ops->mode == MTD_OPS_AUTO_OOB)\n" + "> > ?\t\t\t(int)len);\n" + "> > ?\n" + "> > ?\tif (ops->mode == MTD_OPS_AUTO_OOB)\n" "> > -\t\toobsize = this->ecclayout->oobavail;\n" "> > +\t\toobsize = mtd->oobavail;\n" - "> > \302\240\telse\n" - "> > \302\240\t\toobsize = mtd->oobsize;\n" - "> > \302\240\n" + "> > ?\telse\n" + "> > ?\t\toobsize = mtd->oobsize;\n" + "> > ?\n" "> > @@ -1230,7 +1230,7 @@ static int onenand_read_ops_nolock(struct\n" "> > mtd_info *mtd, loff_t from,\n" - "> > \302\240\t\t\t(int)len);\n" - "> > \302\240\n" - "> > \302\240\tif (ops->mode == MTD_OPS_AUTO_OOB)\n" + "> > ?\t\t\t(int)len);\n" + "> > ?\n" + "> > ?\tif (ops->mode == MTD_OPS_AUTO_OOB)\n" "> > -\t\toobsize = this->ecclayout->oobavail;\n" "> > +\t\toobsize = mtd->oobavail;\n" - "> > \302\240\telse\n" - "> > \302\240\t\toobsize = mtd->oobsize;\n" - "> > \302\240\n" + "> > ?\telse\n" + "> > ?\t\toobsize = mtd->oobsize;\n" + "> > ?\n" "> > @@ -1365,7 +1365,7 @@ static int onenand_read_oob_nolock(struct\n" "> > mtd_info *mtd, loff_t from,\n" - "> > \302\240\tops->oobretlen = 0;\n" - "> > \302\240\n" - "> > \302\240\tif (mode == MTD_OPS_AUTO_OOB)\n" + "> > ?\tops->oobretlen = 0;\n" + "> > ?\n" + "> > ?\tif (mode == MTD_OPS_AUTO_OOB)\n" "> > -\t\toobsize = this->ecclayout->oobavail;\n" "> > +\t\toobsize = mtd->oobavail;\n" - "> > \302\240\telse\n" - "> > \302\240\t\toobsize = mtd->oobsize;\n" - "> > \302\240\n" + "> > ?\telse\n" + "> > ?\t\toobsize = mtd->oobsize;\n" + "> > ?\n" "> > @@ -1887,7 +1887,7 @@ static int onenand_write_ops_nolock(struct\n" "> > mtd_info *mtd, loff_t to,\n" - "> > \302\240\t\treturn 0;\n" - "> > \302\240\n" - "> > \302\240\tif (ops->mode == MTD_OPS_AUTO_OOB)\n" + "> > ?\t\treturn 0;\n" + "> > ?\n" + "> > ?\tif (ops->mode == MTD_OPS_AUTO_OOB)\n" "> > -\t\toobsize = this->ecclayout->oobavail;\n" "> > +\t\toobsize = mtd->oobavail;\n" - "> > \302\240\telse\n" - "> > \302\240\t\toobsize = mtd->oobsize;\n" - "> > \302\240\n" + "> > ?\telse\n" + "> > ?\t\toobsize = mtd->oobsize;\n" + "> > ?\n" "> > @@ -2063,7 +2063,7 @@ static int onenand_write_oob_nolock(struct\n" "> > mtd_info *mtd, loff_t to,\n" - "> > \302\240\tops->oobretlen = 0;\n" - "> > \302\240\n" - "> > \302\240\tif (mode == MTD_OPS_AUTO_OOB)\n" + "> > ?\tops->oobretlen = 0;\n" + "> > ?\n" + "> > ?\tif (mode == MTD_OPS_AUTO_OOB)\n" "> > -\t\toobsize = this->ecclayout->oobavail;\n" "> > +\t\toobsize = mtd->oobavail;\n" - "> > \302\240\telse\n" - "> > \302\240\t\toobsize = mtd->oobsize;\n" + "> > ?\telse\n" + "> > ?\t\toobsize = mtd->oobsize;\n" "> \n" "> This identical construction seems to occur multiple times in multiple\n" "> files. Would it make sense to create a macro for it?\n" @@ -181,4 +158,4 @@ "Embedded Linux and Kernel engineering\n" http://free-electrons.com -c973f5a39e6e96ce6c1899c519f4799c64b1ab6d03aeeea27bcfbac3eda848e0 +b71ae1475d1ff41d095b12ebde052dcc1c12dcb9a6232756900ba19fbc926236
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.