From: lorenzo.pieralisi@arm.com (Lorenzo Pieralisi)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] arm64: dts: juno: Add idle-states to device tree
Date: Tue, 8 Dec 2015 12:11:06 +0000 [thread overview]
Message-ID: <20151208121106.GA404@red-moon> (raw)
In-Reply-To: <1449513481.3012.16.camel@linaro.org>
On Mon, Dec 07, 2015 at 06:38:01PM +0000, Jon Medhurst (Tixy) wrote:
> The latency times were suggested by Lorenzo Pieralisi after some ad hoc
> testing.
>
> Signed-off-by: Jon Medhurst <tixy@linaro.org>
> Acked-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
> ---
>
> Lorenzo, are you happy with my statement that you did 'ad hoc testing'
> to derive the figures or is there something more specific that's worth
> adding?
Well, it is what I did but I would rephrase the commit log. I am
ok with the patch as it is as long as you update the commit log.
"This patch adds idle-states bindings data collected through a set
of benchmarking experiments (latency and energy consumption) on Juno boards.
Lantecies data represents the worst case scenarios as required by the DT
idle-states bindings." or something like that.
Thanks,
Lorenzo
>
> arch/arm64/boot/dts/arm/juno-r1.dts | 28 ++++++++++++++++++++++++++++
> arch/arm64/boot/dts/arm/juno.dts | 28 ++++++++++++++++++++++++++++
> 2 files changed, 56 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/arm/juno-r1.dts b/arch/arm64/boot/dts/arm/juno-r1.dts
> index 93bc3d7..8826f83 100644
> --- a/arch/arm64/boot/dts/arm/juno-r1.dts
> +++ b/arch/arm64/boot/dts/arm/juno-r1.dts
> @@ -60,6 +60,28 @@
> };
> };
>
> + idle-states {
> + entry-method = "arm,psci";
> +
> + CPU_SLEEP_0: cpu-sleep-0 {
> + compatible = "arm,idle-state";
> + arm,psci-suspend-param = <0x0010000>;
> + local-timer-stop;
> + entry-latency-us = <300>;
> + exit-latency-us = <1200>;
> + min-residency-us = <2000>;
> + };
> +
> + CLUSTER_SLEEP_0: cluster-sleep-0 {
> + compatible = "arm,idle-state";
> + arm,psci-suspend-param = <0x1010000>;
> + local-timer-stop;
> + entry-latency-us = <300>;
> + exit-latency-us = <1200>;
> + min-residency-us = <2500>;
> + };
> + };
> +
> A57_0: cpu at 0 {
> compatible = "arm,cortex-a57","arm,armv8";
> reg = <0x0 0x0>;
> @@ -67,6 +89,7 @@
> enable-method = "psci";
> next-level-cache = <&A57_L2>;
> clocks = <&scpi_dvfs 0>;
> + cpu-idle-states = <&CPU_SLEEP_0 &CLUSTER_SLEEP_0>;
> };
>
> A57_1: cpu at 1 {
> @@ -76,6 +99,7 @@
> enable-method = "psci";
> next-level-cache = <&A57_L2>;
> clocks = <&scpi_dvfs 0>;
> + cpu-idle-states = <&CPU_SLEEP_0 &CLUSTER_SLEEP_0>;
> };
>
> A53_0: cpu at 100 {
> @@ -85,6 +109,7 @@
> enable-method = "psci";
> next-level-cache = <&A53_L2>;
> clocks = <&scpi_dvfs 1>;
> + cpu-idle-states = <&CPU_SLEEP_0 &CLUSTER_SLEEP_0>;
> };
>
> A53_1: cpu at 101 {
> @@ -94,6 +119,7 @@
> enable-method = "psci";
> next-level-cache = <&A53_L2>;
> clocks = <&scpi_dvfs 1>;
> + cpu-idle-states = <&CPU_SLEEP_0 &CLUSTER_SLEEP_0>;
> };
>
> A53_2: cpu at 102 {
> @@ -103,6 +129,7 @@
> enable-method = "psci";
> next-level-cache = <&A53_L2>;
> clocks = <&scpi_dvfs 1>;
> + cpu-idle-states = <&CPU_SLEEP_0 &CLUSTER_SLEEP_0>;
> };
>
> A53_3: cpu at 103 {
> @@ -112,6 +139,7 @@
> enable-method = "psci";
> next-level-cache = <&A53_L2>;
> clocks = <&scpi_dvfs 1>;
> + cpu-idle-states = <&CPU_SLEEP_0 &CLUSTER_SLEEP_0>;
> };
>
> A57_L2: l2-cache0 {
> diff --git a/arch/arm64/boot/dts/arm/juno.dts b/arch/arm64/boot/dts/arm/juno.dts
> index 53442b5..dcfcf15 100644
> --- a/arch/arm64/boot/dts/arm/juno.dts
> +++ b/arch/arm64/boot/dts/arm/juno.dts
> @@ -60,6 +60,28 @@
> };
> };
>
> + idle-states {
> + entry-method = "arm,psci";
> +
> + CPU_SLEEP_0: cpu-sleep-0 {
> + compatible = "arm,idle-state";
> + arm,psci-suspend-param = <0x0010000>;
> + local-timer-stop;
> + entry-latency-us = <300>;
> + exit-latency-us = <1200>;
> + min-residency-us = <2000>;
> + };
> +
> + CLUSTER_SLEEP_0: cluster-sleep-0 {
> + compatible = "arm,idle-state";
> + arm,psci-suspend-param = <0x1010000>;
> + local-timer-stop;
> + entry-latency-us = <300>;
> + exit-latency-us = <1200>;
> + min-residency-us = <2500>;
> + };
> + };
> +
> A57_0: cpu at 0 {
> compatible = "arm,cortex-a57","arm,armv8";
> reg = <0x0 0x0>;
> @@ -67,6 +89,7 @@
> enable-method = "psci";
> next-level-cache = <&A57_L2>;
> clocks = <&scpi_dvfs 0>;
> + cpu-idle-states = <&CPU_SLEEP_0 &CLUSTER_SLEEP_0>;
> };
>
> A57_1: cpu at 1 {
> @@ -76,6 +99,7 @@
> enable-method = "psci";
> next-level-cache = <&A57_L2>;
> clocks = <&scpi_dvfs 0>;
> + cpu-idle-states = <&CPU_SLEEP_0 &CLUSTER_SLEEP_0>;
> };
>
> A53_0: cpu at 100 {
> @@ -85,6 +109,7 @@
> enable-method = "psci";
> next-level-cache = <&A53_L2>;
> clocks = <&scpi_dvfs 1>;
> + cpu-idle-states = <&CPU_SLEEP_0 &CLUSTER_SLEEP_0>;
> };
>
> A53_1: cpu at 101 {
> @@ -94,6 +119,7 @@
> enable-method = "psci";
> next-level-cache = <&A53_L2>;
> clocks = <&scpi_dvfs 1>;
> + cpu-idle-states = <&CPU_SLEEP_0 &CLUSTER_SLEEP_0>;
> };
>
> A53_2: cpu at 102 {
> @@ -103,6 +129,7 @@
> enable-method = "psci";
> next-level-cache = <&A53_L2>;
> clocks = <&scpi_dvfs 1>;
> + cpu-idle-states = <&CPU_SLEEP_0 &CLUSTER_SLEEP_0>;
> };
>
> A53_3: cpu at 103 {
> @@ -112,6 +139,7 @@
> enable-method = "psci";
> next-level-cache = <&A53_L2>;
> clocks = <&scpi_dvfs 1>;
> + cpu-idle-states = <&CPU_SLEEP_0 &CLUSTER_SLEEP_0>;
> };
>
> A57_L2: l2-cache0 {
> --
> 2.1.4
>
>
>
prev parent reply other threads:[~2015-12-08 12:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-07 18:38 [PATCH v2] arm64: dts: juno: Add idle-states to device tree Jon Medhurst (Tixy)
2015-12-08 12:11 ` Lorenzo Pieralisi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151208121106.GA404@red-moon \
--to=lorenzo.pieralisi@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.