From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rob Herring Subject: Re: [PATCH v10 14/17] drm: bridge: analogix/dp: try force hpd after plug in lookup failed Date: Tue, 8 Dec 2015 09:09:54 -0600 Message-ID: <20151208150954.GA17979@rob-hp-laptop> References: <1449470239-30667-1-git-send-email-ykk@rock-chips.com> <1449470442-31519-1-git-send-email-ykk@rock-chips.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <1449470442-31519-1-git-send-email-ykk@rock-chips.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Yakir Yang Cc: Krzysztof Kozlowski , Seung-Woo Kim , dri-devel@lists.freedesktop.org, Andrzej Hajda , Gustavo Padovan , linux-samsung-soc@vger.kernel.org, Russell King , linux-rockchip@lists.infradead.org, Kishon Vijay Abraham I , javier@osg.samsung.com, Thierry Reding , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Jingoo Han , emil.l.velikov@gmail.com, linux-kernel@vger.kernel.org, Kyungmin Park , ajaynumb@gmail.com, Andy Yan List-Id: linux-rockchip.vger.kernel.org T24gTW9uLCBEZWMgMDcsIDIwMTUgYXQgMDI6NDA6NDJQTSArMDgwMCwgWWFraXIgWWFuZyB3cm90 ZToKPiBTb21lIGVkcCBzY3JlZW4gZG8gbm90IGhhdmUgaHBkIHNpZ25hbCwgc28gd2UgY2FuJ3Qg anVzdCByZXR1cm4KPiBmYWlsZWQgd2hlbiBocGQgcGx1ZyBpbiBkZXRlY3QgZmFpbGVkLgo+IAo+ IFRoaXMgaXMgYW4gaGFyZHdhcmUgcHJvcGVydHksIHNvIHdlIG5lZWQgYWRkIGEgZGV2aWNldHJl ZSBwcm9wZXJ0eQo+ICJhbmFsb2dpeCxuZWVkLWZvcmNlLWhwZCIgdG8gaW5kaWNhdGUgdGhpcyBz dXRpYXRpb24uCgpJIGNhbiBzZWUgdGhpcyBiZWluZyBjb21tb24uIEp1c3QgbWFrZSBpdCAiZm9y Y2UtaHBkIi4KClJvYgoKPiAKPiBTaWduZWQtb2ZmLWJ5OiBZYWtpciBZYW5nIDx5a2tAcm9jay1j aGlwcy5jb20+Cj4gVGVzdGVkLWJ5OiBKYXZpZXIgTWFydGluZXogQ2FuaWxsYXMgPGphdmllckBv c2cuc2Ftc3VuZy5jb20+Cj4gLS0tCj4gQ2hhbmdlcyBpbiB2MTA6IE5vbmUKPiBDaGFuZ2VzIGlu IHY5OiBOb25lCj4gQ2hhbmdlcyBpbiB2ODogTm9uZQo+IENoYW5nZXMgaW4gdjc6IE5vbmUKPiBD aGFuZ2VzIGluIHY2OiBOb25lCj4gQ2hhbmdlcyBpbiB2NTogTm9uZQo+IENoYW5nZXMgaW4gdjQ6 IE5vbmUKPiBDaGFuZ2VzIGluIHYzOgo+IC0gQWRkICJhbmFsb2dpeCxuZWVkLWZvcmNlLWhwZCIg dG8gaW5kaWNhdGUgd2hldGhlciBkcml2ZXIgbmVlZCBmb2NlCj4gICBocGQgd2hlbiBocGQgZGV0 ZWN0IGZhaWxlZC4KPiAKPiBDaGFuZ2VzIGluIHYyOiBOb25lCj4gCj4gIC4uLi9iaW5kaW5ncy9k aXNwbGF5L2JyaWRnZS9hbmFsb2dpeF9kcC50eHQgICAgICAgIHwgIDQgKystCj4gIC4uLi9iaW5k aW5ncy9kaXNwbGF5L2V4eW5vcy9leHlub3NfZHAudHh0ICAgICAgICAgIHwgIDEgKwo+ICAuLi4v ZGlzcGxheS9yb2NrY2hpcC9hbmFsb2dpeF9kcC1yb2NrY2hpcC50eHQgICAgICB8ICAxICsKPiAg ZHJpdmVycy9ncHUvZHJtL2JyaWRnZS9hbmFsb2dpeC9hbmFsb2dpeF9kcF9jb3JlLmMgfCAzNiAr KysrKysrKysrKysrKysrKysrLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9icmlkZ2UvYW5hbG9naXgv YW5hbG9naXhfZHBfY29yZS5oIHwgIDIgKysKPiAgZHJpdmVycy9ncHUvZHJtL2JyaWRnZS9hbmFs b2dpeC9hbmFsb2dpeF9kcF9yZWcuYyAgfCAgOSArKysrKysKPiAgNiBmaWxlcyBjaGFuZ2VkLCA0 NyBpbnNlcnRpb25zKCspLCA2IGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS9Eb2N1bWVu dGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvZGlzcGxheS9icmlkZ2UvYW5hbG9naXhfZHAudHh0 IGIvRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL2Rpc3BsYXkvYnJpZGdlL2FuYWxv Z2l4X2RwLnR4dAo+IGluZGV4IDc2NTlhN2EuLjc0ZjBlODAgMTAwNjQ0Cj4gLS0tIGEvRG9jdW1l bnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL2Rpc3BsYXkvYnJpZGdlL2FuYWxvZ2l4X2RwLnR4 dAo+ICsrKyBiL0RvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9kaXNwbGF5L2JyaWRn ZS9hbmFsb2dpeF9kcC50eHQKPiBAQCAtMjIsNiArMjIsOSBAQCBSZXF1aXJlZCBwcm9wZXJ0aWVz IGZvciBkcC1jb250cm9sbGVyOgo+ICAJCWZyb20gZ2VuZXJhbCBQSFkgYmluZGluZzogU2hvdWxk IGJlICJkcCIuCj4gIAo+ICBPcHRpb25hbCBwcm9wZXJ0aWVzIGZvciBkcC1jb250cm9sbGVyOgo+ ICsJLWFuYWxvZ2l4LG5lZWQtZm9yY2UtaHBkOgo+ICsJCUluZGljYXRlIGRyaXZlciBuZWVkIGZv cmNlIGhwZCB3aGVuIGhwZCBkZXRlY3QgZmFpbGVkLCB0aGlzCj4gKwkJaXMgdXNlZCBmb3Igc29t ZSBlRFAgc2NyZWVuIHdoaWNoIGRvbid0IGhhdmUgaHBkIHNpZ25hbC4KPiAgCS1ocGQtZ3Bpb3M6 Cj4gIAkJSG90cGx1ZyBkZXRlY3QgR1BJTy4KPiAgCQlJbmRpY2F0ZXMgd2hpY2ggR1BJTyBzaG91 bGQgYmUgdXNlZCBmb3IgaG90cGx1ZyBkZXRlY3Rpb24KPiBAQCAtMzEsNyArMzQsNiBAQCBPcHRp b25hbCBwcm9wZXJ0aWVzIGZvciBkcC1jb250cm9sbGVyOgo+ICAJCSogRG9jdW1lbnRhdGlvbi9k ZXZpY2V0cmVlL2JpbmRpbmdzL2Rpc3BsYXkvZXh5bm9zL2V4eW5vc19kcC50eHQKPiAgCQkqIERv Y3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy92aWRlby9hbmFsb2dpeF9kcC1yb2NrY2hp cC50eHQKPiAgCj4gLQo+ICBbMV06IERvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9t ZWRpYS92aWRlby1pbnRlcmZhY2VzLnR4dAo+ICAtLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tCj4gIAo+ IGRpZmYgLS1naXQgYS9Eb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvZGlzcGxheS9l eHlub3MvZXh5bm9zX2RwLnR4dCBiL0RvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9k aXNwbGF5L2V4eW5vcy9leHlub3NfZHAudHh0Cj4gaW5kZXggOTkwNTA4MS4uODgwMDE2NCAxMDA2 NDQKPiAtLS0gYS9Eb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvZGlzcGxheS9leHlu b3MvZXh5bm9zX2RwLnR4dAo+ICsrKyBiL0RvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5n cy9kaXNwbGF5L2V4eW5vcy9leHlub3NfZHAudHh0Cj4gQEAgLTQxLDYgKzQxLDcgQEAgRm9yIHRo ZSBiZWxvdyBwcm9wZXJ0aWVzLCBwbGVhc2UgcmVmZXIgdG8gQW5hbG9naXggRFAgYmluZGluZyBk b2N1bWVudDoKPiAgCS1waHlzIChyZXF1aXJlZCkKPiAgCS1waHktbmFtZXMgKHJlcXVpcmVkKQo+ ICAJLWhwZC1ncGlvcyAob3B0aW9uYWwpCj4gKwktYW5hbG9naXgsbmVlZC1mb3JjZS1ocGQgKG9w dGlvbmFsKQo+ICAJLXZpZGVvIGludGVyZmFjZXMgKG9wdGlvbmFsKQo+ICAKPiAgRGVwcmVjYXRl ZCBwcm9wZXJ0aWVzIGZvciBEaXNwbGF5UG9ydDoKPiBkaWZmIC0tZ2l0IGEvRG9jdW1lbnRhdGlv bi9kZXZpY2V0cmVlL2JpbmRpbmdzL2Rpc3BsYXkvcm9ja2NoaXAvYW5hbG9naXhfZHAtcm9ja2No aXAudHh0IGIvRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL2Rpc3BsYXkvcm9ja2No aXAvYW5hbG9naXhfZHAtcm9ja2NoaXAudHh0Cj4gaW5kZXggZGFlODZjNC4uMWYxZTU5NCAxMDA2 NDQKPiAtLS0gYS9Eb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvZGlzcGxheS9yb2Nr Y2hpcC9hbmFsb2dpeF9kcC1yb2NrY2hpcC50eHQKPiArKysgYi9Eb2N1bWVudGF0aW9uL2Rldmlj ZXRyZWUvYmluZGluZ3MvZGlzcGxheS9yb2NrY2hpcC9hbmFsb2dpeF9kcC1yb2NrY2hpcC50eHQK PiBAQCAtMzIsNiArMzIsNyBAQCBGb3IgdGhlIGJlbG93IHByb3BlcnRpZXMsIHBsZWFzZSByZWZl ciB0byBBbmFsb2dpeCBEUCBiaW5kaW5nIGRvY3VtZW50Ogo+ICAtIHBoeXMgKHJlcXVpcmVkKQo+ ICAtIHBoeS1uYW1lcyAocmVxdWlyZWQpCj4gIC0gaHBkLWdwaW9zIChvcHRpb25hbCkKPiArLSBh bmFsb2dpeCxuZWVkLWZvcmNlLWhwZCAob3B0aW9uYWwpCj4gIC0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0KPiAgCj4gIEV4YW1wbGU6Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9icmlkZ2Uv YW5hbG9naXgvYW5hbG9naXhfZHBfY29yZS5jIGIvZHJpdmVycy9ncHUvZHJtL2JyaWRnZS9hbmFs b2dpeC9hbmFsb2dpeF9kcF9jb3JlLmMKPiBpbmRleCBhMTE1MDRiLi45NDk2OGU0IDEwMDY0NAo+ IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9icmlkZ2UvYW5hbG9naXgvYW5hbG9naXhfZHBfY29yZS5j Cj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2JyaWRnZS9hbmFsb2dpeC9hbmFsb2dpeF9kcF9jb3Jl LmMKPiBAQCAtNTksMTUgKzU5LDM4IEBAIHN0YXRpYyBpbnQgYW5hbG9naXhfZHBfZGV0ZWN0X2hw ZChzdHJ1Y3QgYW5hbG9naXhfZHBfZGV2aWNlICpkcCkKPiAgewo+ICAJaW50IHRpbWVvdXRfbG9v cCA9IDA7Cj4gIAo+IC0Jd2hpbGUgKGFuYWxvZ2l4X2RwX2dldF9wbHVnX2luX3N0YXR1cyhkcCkg IT0gMCkgewo+ICsJd2hpbGUgKHRpbWVvdXRfbG9vcCA8IERQX1RJTUVPVVRfTE9PUF9DT1VOVCkg ewo+ICsJCWlmIChhbmFsb2dpeF9kcF9nZXRfcGx1Z19pbl9zdGF0dXMoZHApID09IDApCj4gKwkJ CXJldHVybiAwOwo+ICsKPiAgCQl0aW1lb3V0X2xvb3ArKzsKPiAtCQlpZiAodGltZW91dF9sb29w ID4gRFBfVElNRU9VVF9MT09QX0NPVU5UKSB7Cj4gLQkJCWRldl9lcnIoZHAtPmRldiwgImZhaWxl ZCB0byBnZXQgaHBkIHBsdWcgc3RhdHVzXG4iKTsKPiAtCQkJcmV0dXJuIC1FVElNRURPVVQ7Cj4g LQkJfQo+ICAJCXVzbGVlcF9yYW5nZSgxMCwgMTEpOwo+ICAJfQo+ICAKPiArCS8qCj4gKwkgKiBT b21lIGVkcCBzY3JlZW4gZG8gbm90IGhhdmUgaHBkIHNpZ25hbCwgc28gd2UgY2FuJ3QganVzdAo+ ICsJICogcmV0dXJuIGZhaWxlZCB3aGVuIGhwZCBwbHVnIGluIGRldGVjdCBmYWlsZWQsIERUIHBy b3BlcnR5Cj4gKwkgKiAibmVlZC1mb3JjZS1ocGQiIHdvdWxkIGluZGljYXRlIHdoZXRoZXIgZHJp dmVyIG5lZWQgdGhpcy4KPiArCSAqLwo+ICsJaWYgKCFkcC0+bmVlZF9mb3JjZV9ocGQpCj4gKwkJ cmV0dXJuIC1FVElNRURPVVQ7Cj4gKwo+ICsJLyoKPiArCSAqIFRoZSBlRFAgVFJNIGluZGljYXRl IHRoYXQgaWYgSFBEX1NUQVRVUyhSTykgaXMgMCwgQVVYIENICj4gKwkgKiB3aWxsIG5vdCB3b3Jr LCBzbyB3ZSBuZWVkIHRvIGdpdmUgYSBmb3JjZSBocGQgYWN0aW9uIHRvCj4gKwkgKiBzZXQgSFBE X1NUQVRVUyBtYW51YWxseS4KPiArCSAqLwo+ICsJZGV2X2RiZyhkcC0+ZGV2LCAiZmFpbGVkIHRv IGdldCBocGQgcGx1ZyBzdGF0dXMsIHRyeSB0byBmb3JjZSBocGRcbiIpOwo+ICsKPiArCWFuYWxv Z2l4X2RwX2ZvcmNlX2hwZChkcCk7Cj4gKwo+ICsJaWYgKGFuYWxvZ2l4X2RwX2dldF9wbHVnX2lu X3N0YXR1cyhkcCkgIT0gMCkgewo+ICsJCWRldl9lcnIoZHAtPmRldiwgImZhaWxlZCB0byBnZXQg aHBkIHBsdWcgaW4gc3RhdHVzXG4iKTsKPiArCQlyZXR1cm4gLUVJTlZBTDsKPiArCX0KPiArCj4g KwlkZXZfZGJnKGRwLT5kZXYsICJzdWNjZXNzIHRvIGdldCBwbHVnIGluIHN0YXR1cyBhZnRlciBm b3JjZSBocGRcbiIpOwo+ICsKPiAgCXJldHVybiAwOwo+ICB9Cj4gIAo+IEBAIC0xMjQ2LDYgKzEy NjksOSBAQCBpbnQgYW5hbG9naXhfZHBfYmluZChzdHJ1Y3QgZGV2aWNlICpkZXYsIHN0cnVjdCBk cm1fZGV2aWNlICpkcm1fZGV2LAo+ICAJaWYgKElTX0VSUihkcC0+cmVnX2Jhc2UpKQo+ICAJCXJl dHVybiBQVFJfRVJSKGRwLT5yZWdfYmFzZSk7Cj4gIAo+ICsJZHAtPm5lZWRfZm9yY2VfaHBkID0K PiArCQlvZl9wcm9wZXJ0eV9yZWFkX2Jvb2woZGV2LT5vZl9ub2RlLCAiYW5hbG9naXgsbmVlZC1m b3JjZS1ocGQiKTsKPiArCj4gIAlkcC0+aHBkX2dwaW8gPSBvZl9nZXRfbmFtZWRfZ3BpbyhkZXYt Pm9mX25vZGUsICJocGQtZ3Bpb3MiLCAwKTsKPiAgCWlmICghZ3Bpb19pc192YWxpZChkcC0+aHBk X2dwaW8pKQo+ICAJCWRwLT5ocGRfZ3BpbyA9IG9mX2dldF9uYW1lZF9ncGlvKGRldi0+b2Zfbm9k ZSwKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2JyaWRnZS9hbmFsb2dpeC9hbmFsb2dp eF9kcF9jb3JlLmggYi9kcml2ZXJzL2dwdS9kcm0vYnJpZGdlL2FuYWxvZ2l4L2FuYWxvZ2l4X2Rw X2NvcmUuaAo+IGluZGV4IGU2ZjgyNDMuLmQzYzdlMGEgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9n cHUvZHJtL2JyaWRnZS9hbmFsb2dpeC9hbmFsb2dpeF9kcF9jb3JlLmgKPiArKysgYi9kcml2ZXJz L2dwdS9kcm0vYnJpZGdlL2FuYWxvZ2l4L2FuYWxvZ2l4X2RwX2NvcmUuaAo+IEBAIC0xNjAsNiAr MTYwLDcgQEAgc3RydWN0IGFuYWxvZ2l4X2RwX2RldmljZSB7Cj4gIAlzdHJ1Y3QgcGh5CQkqcGh5 Owo+ICAJaW50CQkJZHBtc19tb2RlOwo+ICAJaW50CQkJaHBkX2dwaW87Cj4gKwlib29sICAgICAg ICAgICAgICAgICAgICBuZWVkX2ZvcmNlX2hwZDsKPiAgCj4gIAlzdHJ1Y3QgYW5hbG9naXhfZHBf cGxhdF9kYXRhICpwbGF0X2RhdGE7Cj4gIH07Cj4gQEAgLTE4MCw2ICsxODEsNyBAQCB2b2lkIGFu YWxvZ2l4X2RwX3NldF9hbmFsb2dfcG93ZXJfZG93bihzdHJ1Y3QgYW5hbG9naXhfZHBfZGV2aWNl ICpkcCwKPiAgCQkJCSAgICAgICBib29sIGVuYWJsZSk7Cj4gIHZvaWQgYW5hbG9naXhfZHBfaW5p dF9hbmFsb2dfZnVuYyhzdHJ1Y3QgYW5hbG9naXhfZHBfZGV2aWNlICpkcCk7Cj4gIHZvaWQgYW5h bG9naXhfZHBfaW5pdF9ocGQoc3RydWN0IGFuYWxvZ2l4X2RwX2RldmljZSAqZHApOwo+ICt2b2lk IGFuYWxvZ2l4X2RwX2ZvcmNlX2hwZChzdHJ1Y3QgYW5hbG9naXhfZHBfZGV2aWNlICpkcCk7Cj4g IGVudW0gZHBfaXJxX3R5cGUgYW5hbG9naXhfZHBfZ2V0X2lycV90eXBlKHN0cnVjdCBhbmFsb2dp eF9kcF9kZXZpY2UgKmRwKTsKPiAgdm9pZCBhbmFsb2dpeF9kcF9jbGVhcl9ob3RwbHVnX2ludGVy cnVwdHMoc3RydWN0IGFuYWxvZ2l4X2RwX2RldmljZSAqZHApOwo+ICB2b2lkIGFuYWxvZ2l4X2Rw X3Jlc2V0X2F1eChzdHJ1Y3QgYW5hbG9naXhfZHBfZGV2aWNlICpkcCk7Cj4gZGlmZiAtLWdpdCBh L2RyaXZlcnMvZ3B1L2RybS9icmlkZ2UvYW5hbG9naXgvYW5hbG9naXhfZHBfcmVnLmMgYi9kcml2 ZXJzL2dwdS9kcm0vYnJpZGdlL2FuYWxvZ2l4L2FuYWxvZ2l4X2RwX3JlZy5jCj4gaW5kZXggMjFh MzI4Ny4uYzdlMjk1OSAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vYnJpZGdlL2FuYWxv Z2l4L2FuYWxvZ2l4X2RwX3JlZy5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2JyaWRnZS9hbmFs b2dpeC9hbmFsb2dpeF9kcF9yZWcuYwo+IEBAIC0zNjUsNiArMzY1LDE1IEBAIHZvaWQgYW5hbG9n aXhfZHBfaW5pdF9ocGQoc3RydWN0IGFuYWxvZ2l4X2RwX2RldmljZSAqZHApCj4gIAl3cml0ZWwo cmVnLCBkcC0+cmVnX2Jhc2UgKyBBTkFMT0dJWF9EUF9TWVNfQ1RMXzMpOwo+ICB9Cj4gIAo+ICt2 b2lkIGFuYWxvZ2l4X2RwX2ZvcmNlX2hwZChzdHJ1Y3QgYW5hbG9naXhfZHBfZGV2aWNlICpkcCkK PiArewo+ICsJdTMyIHJlZzsKPiArCj4gKwlyZWcgPSByZWFkbChkcC0+cmVnX2Jhc2UgKyBBTkFM T0dJWF9EUF9TWVNfQ1RMXzMpOwo+ICsJcmVnID0gKEZfSFBEIHwgSFBEX0NUUkwpOwo+ICsJd3Jp dGVsKHJlZywgZHAtPnJlZ19iYXNlICsgQU5BTE9HSVhfRFBfU1lTX0NUTF8zKTsKPiArfQo+ICsK PiAgZW51bSBkcF9pcnFfdHlwZSBhbmFsb2dpeF9kcF9nZXRfaXJxX3R5cGUoc3RydWN0IGFuYWxv Z2l4X2RwX2RldmljZSAqZHApCj4gIHsKPiAgCXUzMiByZWc7Cj4gLS0gCj4gMS45LjEKPiAKPiAK X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0 cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 From: robh@kernel.org (Rob Herring) Date: Tue, 8 Dec 2015 09:09:54 -0600 Subject: [PATCH v10 14/17] drm: bridge: analogix/dp: try force hpd after plug in lookup failed In-Reply-To: <1449470442-31519-1-git-send-email-ykk@rock-chips.com> References: <1449470239-30667-1-git-send-email-ykk@rock-chips.com> <1449470442-31519-1-git-send-email-ykk@rock-chips.com> Message-ID: <20151208150954.GA17979@rob-hp-laptop> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Mon, Dec 07, 2015 at 02:40:42PM +0800, Yakir Yang wrote: > Some edp screen do not have hpd signal, so we can't just return > failed when hpd plug in detect failed. > > This is an hardware property, so we need add a devicetree property > "analogix,need-force-hpd" to indicate this sutiation. I can see this being common. Just make it "force-hpd". Rob > > Signed-off-by: Yakir Yang > Tested-by: Javier Martinez Canillas > --- > Changes in v10: None > Changes in v9: None > Changes in v8: None > Changes in v7: None > Changes in v6: None > Changes in v5: None > Changes in v4: None > Changes in v3: > - Add "analogix,need-force-hpd" to indicate whether driver need foce > hpd when hpd detect failed. > > Changes in v2: None > > .../bindings/display/bridge/analogix_dp.txt | 4 ++- > .../bindings/display/exynos/exynos_dp.txt | 1 + > .../display/rockchip/analogix_dp-rockchip.txt | 1 + > drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 36 +++++++++++++++++++--- > drivers/gpu/drm/bridge/analogix/analogix_dp_core.h | 2 ++ > drivers/gpu/drm/bridge/analogix/analogix_dp_reg.c | 9 ++++++ > 6 files changed, 47 insertions(+), 6 deletions(-) > > diff --git a/Documentation/devicetree/bindings/display/bridge/analogix_dp.txt b/Documentation/devicetree/bindings/display/bridge/analogix_dp.txt > index 7659a7a..74f0e80 100644 > --- a/Documentation/devicetree/bindings/display/bridge/analogix_dp.txt > +++ b/Documentation/devicetree/bindings/display/bridge/analogix_dp.txt > @@ -22,6 +22,9 @@ Required properties for dp-controller: > from general PHY binding: Should be "dp". > > Optional properties for dp-controller: > + -analogix,need-force-hpd: > + Indicate driver need force hpd when hpd detect failed, this > + is used for some eDP screen which don't have hpd signal. > -hpd-gpios: > Hotplug detect GPIO. > Indicates which GPIO should be used for hotplug detection > @@ -31,7 +34,6 @@ Optional properties for dp-controller: > * Documentation/devicetree/bindings/display/exynos/exynos_dp.txt > * Documentation/devicetree/bindings/video/analogix_dp-rockchip.txt > > - > [1]: Documentation/devicetree/bindings/media/video-interfaces.txt > ------------------------------------------------------------------------------- > > diff --git a/Documentation/devicetree/bindings/display/exynos/exynos_dp.txt b/Documentation/devicetree/bindings/display/exynos/exynos_dp.txt > index 9905081..8800164 100644 > --- a/Documentation/devicetree/bindings/display/exynos/exynos_dp.txt > +++ b/Documentation/devicetree/bindings/display/exynos/exynos_dp.txt > @@ -41,6 +41,7 @@ For the below properties, please refer to Analogix DP binding document: > -phys (required) > -phy-names (required) > -hpd-gpios (optional) > + -analogix,need-force-hpd (optional) > -video interfaces (optional) > > Deprecated properties for DisplayPort: > diff --git a/Documentation/devicetree/bindings/display/rockchip/analogix_dp-rockchip.txt b/Documentation/devicetree/bindings/display/rockchip/analogix_dp-rockchip.txt > index dae86c4..1f1e594 100644 > --- a/Documentation/devicetree/bindings/display/rockchip/analogix_dp-rockchip.txt > +++ b/Documentation/devicetree/bindings/display/rockchip/analogix_dp-rockchip.txt > @@ -32,6 +32,7 @@ For the below properties, please refer to Analogix DP binding document: > - phys (required) > - phy-names (required) > - hpd-gpios (optional) > +- analogix,need-force-hpd (optional) > ------------------------------------------------------------------------------- > > Example: > diff --git a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c > index a11504b..94968e4 100644 > --- a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c > +++ b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c > @@ -59,15 +59,38 @@ static int analogix_dp_detect_hpd(struct analogix_dp_device *dp) > { > int timeout_loop = 0; > > - while (analogix_dp_get_plug_in_status(dp) != 0) { > + while (timeout_loop < DP_TIMEOUT_LOOP_COUNT) { > + if (analogix_dp_get_plug_in_status(dp) == 0) > + return 0; > + > timeout_loop++; > - if (timeout_loop > DP_TIMEOUT_LOOP_COUNT) { > - dev_err(dp->dev, "failed to get hpd plug status\n"); > - return -ETIMEDOUT; > - } > usleep_range(10, 11); > } > > + /* > + * Some edp screen do not have hpd signal, so we can't just > + * return failed when hpd plug in detect failed, DT property > + * "need-force-hpd" would indicate whether driver need this. > + */ > + if (!dp->need_force_hpd) > + return -ETIMEDOUT; > + > + /* > + * The eDP TRM indicate that if HPD_STATUS(RO) is 0, AUX CH > + * will not work, so we need to give a force hpd action to > + * set HPD_STATUS manually. > + */ > + dev_dbg(dp->dev, "failed to get hpd plug status, try to force hpd\n"); > + > + analogix_dp_force_hpd(dp); > + > + if (analogix_dp_get_plug_in_status(dp) != 0) { > + dev_err(dp->dev, "failed to get hpd plug in status\n"); > + return -EINVAL; > + } > + > + dev_dbg(dp->dev, "success to get plug in status after force hpd\n"); > + > return 0; > } > > @@ -1246,6 +1269,9 @@ int analogix_dp_bind(struct device *dev, struct drm_device *drm_dev, > if (IS_ERR(dp->reg_base)) > return PTR_ERR(dp->reg_base); > > + dp->need_force_hpd = > + of_property_read_bool(dev->of_node, "analogix,need-force-hpd"); > + > dp->hpd_gpio = of_get_named_gpio(dev->of_node, "hpd-gpios", 0); > if (!gpio_is_valid(dp->hpd_gpio)) > dp->hpd_gpio = of_get_named_gpio(dev->of_node, > diff --git a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.h b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.h > index e6f8243..d3c7e0a 100644 > --- a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.h > +++ b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.h > @@ -160,6 +160,7 @@ struct analogix_dp_device { > struct phy *phy; > int dpms_mode; > int hpd_gpio; > + bool need_force_hpd; > > struct analogix_dp_plat_data *plat_data; > }; > @@ -180,6 +181,7 @@ void analogix_dp_set_analog_power_down(struct analogix_dp_device *dp, > bool enable); > void analogix_dp_init_analog_func(struct analogix_dp_device *dp); > void analogix_dp_init_hpd(struct analogix_dp_device *dp); > +void analogix_dp_force_hpd(struct analogix_dp_device *dp); > enum dp_irq_type analogix_dp_get_irq_type(struct analogix_dp_device *dp); > void analogix_dp_clear_hotplug_interrupts(struct analogix_dp_device *dp); > void analogix_dp_reset_aux(struct analogix_dp_device *dp); > diff --git a/drivers/gpu/drm/bridge/analogix/analogix_dp_reg.c b/drivers/gpu/drm/bridge/analogix/analogix_dp_reg.c > index 21a3287..c7e2959 100644 > --- a/drivers/gpu/drm/bridge/analogix/analogix_dp_reg.c > +++ b/drivers/gpu/drm/bridge/analogix/analogix_dp_reg.c > @@ -365,6 +365,15 @@ void analogix_dp_init_hpd(struct analogix_dp_device *dp) > writel(reg, dp->reg_base + ANALOGIX_DP_SYS_CTL_3); > } > > +void analogix_dp_force_hpd(struct analogix_dp_device *dp) > +{ > + u32 reg; > + > + reg = readl(dp->reg_base + ANALOGIX_DP_SYS_CTL_3); > + reg = (F_HPD | HPD_CTRL); > + writel(reg, dp->reg_base + ANALOGIX_DP_SYS_CTL_3); > +} > + > enum dp_irq_type analogix_dp_get_irq_type(struct analogix_dp_device *dp) > { > u32 reg; > -- > 1.9.1 > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933079AbbLHPKD (ORCPT ); Tue, 8 Dec 2015 10:10:03 -0500 Received: from mail.kernel.org ([198.145.29.136]:51331 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932383AbbLHPKA (ORCPT ); Tue, 8 Dec 2015 10:10:00 -0500 Date: Tue, 8 Dec 2015 09:09:54 -0600 From: Rob Herring To: Yakir Yang Cc: Inki Dae , Mark Yao , Jingoo Han , Heiko Stuebner , Thierry Reding , Krzysztof Kozlowski , Andrzej Hajda , Joonyoung Shim , Seung-Woo Kim , Kyungmin Park , Russell King , emil.l.velikov@gmail.com, Gustavo Padovan , Kishon Vijay Abraham I , ajaynumb@gmail.com, javier@osg.samsung.com, Andy Yan , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v10 14/17] drm: bridge: analogix/dp: try force hpd after plug in lookup failed Message-ID: <20151208150954.GA17979@rob-hp-laptop> References: <1449470239-30667-1-git-send-email-ykk@rock-chips.com> <1449470442-31519-1-git-send-email-ykk@rock-chips.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1449470442-31519-1-git-send-email-ykk@rock-chips.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Dec 07, 2015 at 02:40:42PM +0800, Yakir Yang wrote: > Some edp screen do not have hpd signal, so we can't just return > failed when hpd plug in detect failed. > > This is an hardware property, so we need add a devicetree property > "analogix,need-force-hpd" to indicate this sutiation. I can see this being common. Just make it "force-hpd". Rob > > Signed-off-by: Yakir Yang > Tested-by: Javier Martinez Canillas > --- > Changes in v10: None > Changes in v9: None > Changes in v8: None > Changes in v7: None > Changes in v6: None > Changes in v5: None > Changes in v4: None > Changes in v3: > - Add "analogix,need-force-hpd" to indicate whether driver need foce > hpd when hpd detect failed. > > Changes in v2: None > > .../bindings/display/bridge/analogix_dp.txt | 4 ++- > .../bindings/display/exynos/exynos_dp.txt | 1 + > .../display/rockchip/analogix_dp-rockchip.txt | 1 + > drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 36 +++++++++++++++++++--- > drivers/gpu/drm/bridge/analogix/analogix_dp_core.h | 2 ++ > drivers/gpu/drm/bridge/analogix/analogix_dp_reg.c | 9 ++++++ > 6 files changed, 47 insertions(+), 6 deletions(-) > > diff --git a/Documentation/devicetree/bindings/display/bridge/analogix_dp.txt b/Documentation/devicetree/bindings/display/bridge/analogix_dp.txt > index 7659a7a..74f0e80 100644 > --- a/Documentation/devicetree/bindings/display/bridge/analogix_dp.txt > +++ b/Documentation/devicetree/bindings/display/bridge/analogix_dp.txt > @@ -22,6 +22,9 @@ Required properties for dp-controller: > from general PHY binding: Should be "dp". > > Optional properties for dp-controller: > + -analogix,need-force-hpd: > + Indicate driver need force hpd when hpd detect failed, this > + is used for some eDP screen which don't have hpd signal. > -hpd-gpios: > Hotplug detect GPIO. > Indicates which GPIO should be used for hotplug detection > @@ -31,7 +34,6 @@ Optional properties for dp-controller: > * Documentation/devicetree/bindings/display/exynos/exynos_dp.txt > * Documentation/devicetree/bindings/video/analogix_dp-rockchip.txt > > - > [1]: Documentation/devicetree/bindings/media/video-interfaces.txt > ------------------------------------------------------------------------------- > > diff --git a/Documentation/devicetree/bindings/display/exynos/exynos_dp.txt b/Documentation/devicetree/bindings/display/exynos/exynos_dp.txt > index 9905081..8800164 100644 > --- a/Documentation/devicetree/bindings/display/exynos/exynos_dp.txt > +++ b/Documentation/devicetree/bindings/display/exynos/exynos_dp.txt > @@ -41,6 +41,7 @@ For the below properties, please refer to Analogix DP binding document: > -phys (required) > -phy-names (required) > -hpd-gpios (optional) > + -analogix,need-force-hpd (optional) > -video interfaces (optional) > > Deprecated properties for DisplayPort: > diff --git a/Documentation/devicetree/bindings/display/rockchip/analogix_dp-rockchip.txt b/Documentation/devicetree/bindings/display/rockchip/analogix_dp-rockchip.txt > index dae86c4..1f1e594 100644 > --- a/Documentation/devicetree/bindings/display/rockchip/analogix_dp-rockchip.txt > +++ b/Documentation/devicetree/bindings/display/rockchip/analogix_dp-rockchip.txt > @@ -32,6 +32,7 @@ For the below properties, please refer to Analogix DP binding document: > - phys (required) > - phy-names (required) > - hpd-gpios (optional) > +- analogix,need-force-hpd (optional) > ------------------------------------------------------------------------------- > > Example: > diff --git a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c > index a11504b..94968e4 100644 > --- a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c > +++ b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c > @@ -59,15 +59,38 @@ static int analogix_dp_detect_hpd(struct analogix_dp_device *dp) > { > int timeout_loop = 0; > > - while (analogix_dp_get_plug_in_status(dp) != 0) { > + while (timeout_loop < DP_TIMEOUT_LOOP_COUNT) { > + if (analogix_dp_get_plug_in_status(dp) == 0) > + return 0; > + > timeout_loop++; > - if (timeout_loop > DP_TIMEOUT_LOOP_COUNT) { > - dev_err(dp->dev, "failed to get hpd plug status\n"); > - return -ETIMEDOUT; > - } > usleep_range(10, 11); > } > > + /* > + * Some edp screen do not have hpd signal, so we can't just > + * return failed when hpd plug in detect failed, DT property > + * "need-force-hpd" would indicate whether driver need this. > + */ > + if (!dp->need_force_hpd) > + return -ETIMEDOUT; > + > + /* > + * The eDP TRM indicate that if HPD_STATUS(RO) is 0, AUX CH > + * will not work, so we need to give a force hpd action to > + * set HPD_STATUS manually. > + */ > + dev_dbg(dp->dev, "failed to get hpd plug status, try to force hpd\n"); > + > + analogix_dp_force_hpd(dp); > + > + if (analogix_dp_get_plug_in_status(dp) != 0) { > + dev_err(dp->dev, "failed to get hpd plug in status\n"); > + return -EINVAL; > + } > + > + dev_dbg(dp->dev, "success to get plug in status after force hpd\n"); > + > return 0; > } > > @@ -1246,6 +1269,9 @@ int analogix_dp_bind(struct device *dev, struct drm_device *drm_dev, > if (IS_ERR(dp->reg_base)) > return PTR_ERR(dp->reg_base); > > + dp->need_force_hpd = > + of_property_read_bool(dev->of_node, "analogix,need-force-hpd"); > + > dp->hpd_gpio = of_get_named_gpio(dev->of_node, "hpd-gpios", 0); > if (!gpio_is_valid(dp->hpd_gpio)) > dp->hpd_gpio = of_get_named_gpio(dev->of_node, > diff --git a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.h b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.h > index e6f8243..d3c7e0a 100644 > --- a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.h > +++ b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.h > @@ -160,6 +160,7 @@ struct analogix_dp_device { > struct phy *phy; > int dpms_mode; > int hpd_gpio; > + bool need_force_hpd; > > struct analogix_dp_plat_data *plat_data; > }; > @@ -180,6 +181,7 @@ void analogix_dp_set_analog_power_down(struct analogix_dp_device *dp, > bool enable); > void analogix_dp_init_analog_func(struct analogix_dp_device *dp); > void analogix_dp_init_hpd(struct analogix_dp_device *dp); > +void analogix_dp_force_hpd(struct analogix_dp_device *dp); > enum dp_irq_type analogix_dp_get_irq_type(struct analogix_dp_device *dp); > void analogix_dp_clear_hotplug_interrupts(struct analogix_dp_device *dp); > void analogix_dp_reset_aux(struct analogix_dp_device *dp); > diff --git a/drivers/gpu/drm/bridge/analogix/analogix_dp_reg.c b/drivers/gpu/drm/bridge/analogix/analogix_dp_reg.c > index 21a3287..c7e2959 100644 > --- a/drivers/gpu/drm/bridge/analogix/analogix_dp_reg.c > +++ b/drivers/gpu/drm/bridge/analogix/analogix_dp_reg.c > @@ -365,6 +365,15 @@ void analogix_dp_init_hpd(struct analogix_dp_device *dp) > writel(reg, dp->reg_base + ANALOGIX_DP_SYS_CTL_3); > } > > +void analogix_dp_force_hpd(struct analogix_dp_device *dp) > +{ > + u32 reg; > + > + reg = readl(dp->reg_base + ANALOGIX_DP_SYS_CTL_3); > + reg = (F_HPD | HPD_CTRL); > + writel(reg, dp->reg_base + ANALOGIX_DP_SYS_CTL_3); > +} > + > enum dp_irq_type analogix_dp_get_irq_type(struct analogix_dp_device *dp) > { > u32 reg; > -- > 1.9.1 > >