From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtpbg64.qq.com (smtpbg64.qq.com [103.7.28.238]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 986071A0F00 for ; Tue, 8 Dec 2015 18:37:25 +1100 (AEDT) Received: from DZ-PC-031 (unknown [221.224.30.42]) by esmtp4.qq.com (ESMTP) with SMTP id 0 for ; Tue, 08 Dec 2015 15:30:06 +0800 (CST) Date: Tue, 8 Dec 2015 15:30:13 +0800 From: "wen.pu@powercore.com.cn" To: linuxppc-dev Subject: [PATCH] powerpc/opal: add warning for unimplemented OPAL message type Mime-Version: 1.0 Message-ID: <20151208153012239673106@powercore.com.cn> Content-Type: multipart/alternative; boundary="----=_001_NextPart862661157014_=----" List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , This is a multi-part message in MIME format. ------=_001_NextPart862661157014_=---- Content-Type: text/plain; charset="GB2312" Content-Transfer-Encoding: base64 SSBmb3VuZCB0aGF0IHRoZXJlIGFyZSB1bmltcGxlbWVudGVkIE9QQUwgbWVzc2FnZSB0eXBlcyAi T1BBTF9NU0dfRVBPVyIgYW5kIA0KIk9QQUxfTVNHX0RQTyIgaW4gUG93ZXJOViBQbGF0Zm9ybS4g SWYgc2tpYm9vdCBzZW5kIHN1Y2ggbWVzc2FnZXMgdG8ga2VybmVsLCANCm5vdGhpbmcgd2lsbCBo YXBwZW4obm90aWZpZXJfY2FsbF9jaGFpbigpIHdpbGwgc2lsZW50bHkgZHJvcCBpdCkuIFNvIEkg YWRkIGEgd2FybmluZyANCnRvIGluZm9ybSB3aGF0IGhhcyBoYXBwZW5lZCwgaXMgaXQgbmVjZXNz YXJ5PyANCg0KU2lnbmVkLW9mZi1ieTogV2VuIFB1IDx3ZW4ucHVAcG93ZXJjb3JlLmNvbS5jbj4N Ci0tLQ0KZGlmZiAtLWdpdCBhL2FyY2gvcG93ZXJwYy9wbGF0Zm9ybXMvcG93ZXJudi9vcGFsLmMg Yi9hcmNoL3Bvd2VycGMvcGxhdGZvcm1zL3Bvd2VybnYvb3BhbC5jDQppbmRleCBmMDg0YWZhLi5l ZjQ5OGFiIDEwMDY0NA0KLS0tIGEvYXJjaC9wb3dlcnBjL3BsYXRmb3Jtcy9wb3dlcm52L29wYWwu Yw0KKysrIGIvYXJjaC9wb3dlcnBjL3BsYXRmb3Jtcy9wb3dlcm52L29wYWwuYw0KQEAgLTI4MSw2 ICsyODEsMTAgQEAgc3RhdGljIHZvaWQgb3BhbF9oYW5kbGVfbWVzc2FnZSh2b2lkKQ0KICBwcl93 YXJuaW5nKCIlczogVW5rbm93biBtZXNzYWdlIHR5cGU6ICV1XG4iLCBfX2Z1bmNfXywgdHlwZSk7 DQogIHJldHVybjsNCiAgfQ0KKyBpZih0eXBlID09IE9QQUxfTVNHX0VQT1cgfHwgdHlwZSA9PSBP UEFMX01TR19EUE8pIHsNCisgcHJfd2FybmluZygiJXM6IFVuaW1wbGVtZW50ZWQgbWVzc2FnZSB0 eXBlOiAldVxuIiwgX19mdW5jX18sIHR5cGUpOw0KKyByZXR1cm47DQorIH0NCiAgb3BhbF9tZXNz YWdlX2RvX25vdGlmeSh0eXBlLCAodm9pZCAqKSZtc2cpOw0KIH0NCi0tLQ0KDQpUaGFua3MhDQpX ZW4gUHUNCg== ------=_001_NextPart862661157014_=---- Content-Type: text/html; charset="GB2312" Content-Transfer-Encoding: quoted-printable =0A
I found that there are unimple= mented OPAL message types "OPAL_MSG_EPOW" and 
"OPAL_MSG_DPO" in PowerNV Platform. If skiboot= send such messages to kernel, 
nothing will ha= ppen(notifier_call_chain() will silently drop it).= So I add a warning 
to inform what has happened, is it necessary? 

Signed-off-by: Wen Pu <wen.pu@powercore.com.cn>
---
=
diff --git a/arch/powerpc/platforms/powernv/opal.c b/a= rch/powerpc/platforms/powernv/opal.c
index f084afa..ef498ab 1= 00644
--- a/arch/powerpc/platforms/powernv/opal.c
+++ b/ar= ch/powerpc/platforms/powernv/opal.c
@@ -281,6 +281,10 @@=  static void opal_handle_message(void)
  p= r_warning("%s: Unknown message type: %u\n", __fun= c__, type);
  return;
  }
+ if(ty= pe =3D=3D OPAL_MSG_EPOW || type =3D=3D OPAL_= MSG_DPO) {
+ pr_warning("%s: Unimplemented mes= sage type: %u\n", __func__, type);
+ retur= n;
+ }
  opal_message_do_notify(type, (void *= )&msg);
 }
---
=0A

Thank= s!
Wen Pu
=0A ------=_001_NextPart862661157014_=------