All of lore.kernel.org
 help / color / mirror / Atom feed
From: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
To: Rasmus Villemoes <linux@rasmusvillemoes.dk>
Cc: Lee Jones <lee.jones@linaro.org>,
	<patches@opensource.wolfsonmicro.com>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mfd: wm831x: fix broken wm831x_unique_id_show
Date: Tue, 8 Dec 2015 16:30:21 +0000	[thread overview]
Message-ID: <20151208163021.GF6058@localhost.localdomain> (raw)
In-Reply-To: <1449358779-19066-1-git-send-email-linux@rasmusvillemoes.dk>

On Sun, Dec 06, 2015 at 12:39:39AM +0100, Rasmus Villemoes wrote:
> wm831x_unique_id_show currently displays an interesting pattern of '0'
> and '3' characters which isn't very useful (figuring out why is left
> as an exercise for the reader). Presumably "buf[i]" should have been
> "id[i] & 0xff".
> 
> But while there, it is much simpler to simply use %phN and do all the
> formatting at once.
> 
> Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
> ---

Acked-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>

Thanks,
Charles

  reply	other threads:[~2015-12-08 16:30 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-05 23:39 [PATCH] mfd: wm831x: fix broken wm831x_unique_id_show Rasmus Villemoes
2015-12-08 16:30 ` Charles Keepax [this message]
2015-12-09  8:50 ` Lee Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151208163021.GF6058@localhost.localdomain \
    --to=ckeepax@opensource.wolfsonmicro.com \
    --cc=lee.jones@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@rasmusvillemoes.dk \
    --cc=patches@opensource.wolfsonmicro.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.