Re: [PATCH] cpufreq, intel_pstate, minor cleanup for FRAC_BITS

[Viresh Kumar <viresh.kumar@linaro.org>]

On 08-12-15, 13:44, Prarit Bhargava wrote:
> 785ee27 ("cpufreq: intel_pstate: Fix limits->max_perf rounding error")
> hardcodes the value of FRAC_BITS.  This patch fixes that minor issue.
> 
> Cc: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
> Cc: Len Brown <lenb@kernel.org>
> Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>
> Cc: Viresh Kumar <viresh.kumar@linaro.org>
> Signed-off-by: Prarit Bhargava <prarit@redhat.com>
> ---
>  drivers/cpufreq/intel_pstate.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/cpufreq/intel_pstate.c b/drivers/cpufreq/intel_pstate.c
> index 4d07cbd..98fb882 100644
> --- a/drivers/cpufreq/intel_pstate.c
> +++ b/drivers/cpufreq/intel_pstate.c
> @@ -1123,7 +1123,7 @@ static int intel_pstate_set_policy(struct cpufreq_policy *policy)
>  				   limits->max_sysfs_pct);
>  	limits->max_perf_pct = max(limits->min_policy_pct,
>  				   limits->max_perf_pct);
> -	limits->max_perf = round_up(limits->max_perf, 8);
> +	limits->max_perf = round_up(limits->max_perf, FRAC_BITS);
>  
>  	/* Make sure min_perf_pct <= max_perf_pct */
>  	limits->min_perf_pct = min(limits->max_perf_pct, limits->min_perf_pct);

Acked-by: Viresh Kumar <viresh.kumar@linaro.org>

-- 
viresh