Re: [PATCH] perf/tui: Change default selection background color to yellow

[Borislav Petkov <bp@alien8.de>]

Hey acme,

it seems you've forgotten this one.

I still need it please :-)

On Thu, Mar 05, 2015 at 11:32:13AM +0100, Ingo Molnar wrote:
> 
> Boris reported that 'perf top' is unusable on his default 'black on 
> white' terminal, which uses (eye friendly) light-grey as a background 
> color.
> 
> The reason is that the TUI cursor for the current selection line uses 
> HE_COLORSET_SELECTED, and that has a default background color of 
> 'lightgrey' - which is a common terminal background choice and thus 
> the colors conflict.
> 
> Use yellow as the background color instead: that should be an uncommon 
> terminal background, yet it's still ergonomic on both black and 
> white/grey terminals.
> 
> [ It would be a better solution to straight out detect color
>   collisions and resolve them reasonably by converting them to RGB and
>   calculating color space distances, but I was unable to find
>   proper documentation for SLtt_get_color_object() to recover the
>   current color scheme so I gave up ... Yellow works well enough. ]
> 
> Reported-by: Borislav Petkov <bp@alien8.de>
> Cc: Arnaldo Carvalho de Melo <acme@kernel.org>
> Cc: David Binderman <dcb314@hotmail.com>
> Cc: Jiri Olsa <jolsa@kernel.org>
> Signed-off-by: Ingo Molnar <mingo@kernel.org>
> ---
>  tools/perf/ui/browser.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/perf/ui/browser.c b/tools/perf/ui/browser.c
> index 6680fa5cb9dd..688acb94c01f 100644
> --- a/tools/perf/ui/browser.c
> +++ b/tools/perf/ui/browser.c
> @@ -499,7 +499,7 @@ static struct ui_browser_colorset {
>  		.colorset = HE_COLORSET_SELECTED,
>  		.name	  = "selected",
>  		.fg	  = "black",
> -		.bg	  = "lightgray",
> +		.bg	  = "yellow",
>  	},
>  	{
>  		.colorset = HE_COLORSET_CODE,
> 

-- 
Regards/Gruss,
    Boris.

ECO tip #101: Trim your mails when you reply.