All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: michal.kazior@tieto.com
Cc: ath10k@lists.infradead.org
Subject: re: ath10k: replace vdev_id and tid in skb cb
Date: Wed, 9 Dec 2015 13:49:35 +0300	[thread overview]
Message-ID: <20151209104935.GL3173@mwanda> (raw)

Hello Michal Kazior,

This is a semi-automatic email about new static checker warnings.

The patch 609db229b42f: "ath10k: replace vdev_id and tid in skb cb" 
from Nov 18, 2015, leads to the following Smatch complaint:

drivers/net/wireless/ath/ath10k/htt_tx.c:450 ath10k_htt_tx_get_vdev_id()
	 warn: variable dereferenced before check 'cb->vif' (see line 446)

drivers/net/wireless/ath/ath10k/htt_tx.c
   445		struct ath10k_skb_cb *cb = ATH10K_SKB_CB(skb);
   446		struct ath10k_vif *arvif = (void *)cb->vif->drv_priv;
                                                   ^^^^^^^^^
Dereference.

   447	
   448		if (info->flags & IEEE80211_TX_CTL_TX_OFFCHAN)
   449			return ar->scan.vdev_id;
   450		else if (cb->vif)
                         ^^^^^^^
Checked too late.

   451			return arvif->vdev_id;
   452		else if (ar->monitor_started)

See also:
drivers/net/wireless/ath/ath10k/wmi.c:1830 ath10k_wmi_op_gen_mgmt_tx() warn: variable dereferenced before check 'cb->vif' (see line 1818)

regards,
dan carpenter

_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

             reply	other threads:[~2015-12-09 10:50 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-09 10:49 Dan Carpenter [this message]
2015-12-10 13:18 ` ath10k: replace vdev_id and tid in skb cb Michal Kazior

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151209104935.GL3173@mwanda \
    --to=dan.carpenter@oracle.com \
    --cc=ath10k@lists.infradead.org \
    --cc=michal.kazior@tieto.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.