From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wei Liu Subject: Re: [PATCH XEN v6 14/32] tools: Remove xc_map_foreign_batch Date: Wed, 9 Dec 2015 12:22:13 +0000 Message-ID: <20151209122213.GG23818@citrix.com> References: <1449141675.4424.125.camel@citrix.com> <1449141749-14940-1-git-send-email-ian.campbell@citrix.com> <1449141749-14940-15-git-send-email-ian.campbell@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <1449141749-14940-15-git-send-email-ian.campbell@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: George Dunlap , wei.liu2@citrix.com, ian.jackson@eu.citrix.com, xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On Thu, Dec 03, 2015 at 11:22:11AM +0000, Ian Campbell wrote: > It can trivially be replaced by xc_map_foreign_pages which is the > interface I want to move to going forward (by standardising on _bulk > but handling err=NULL as _pages does). > > The callers of _batch are checking a mixture of a NULL return or > looking to see if the top nibble of the (usually sole) mfn they pass > has been modified to be non-zero to detect errors. _pages never > modifies the mfn it was given (it's const) and returns NULL on > failure, so adjust the error handling where necessary. Some callers > use a copy of the mfn array, for reuse on failure with _batch, which > is no longer necessary as _pages doesn't modify the array, however I > haven't cleaned that up here. > > This reduces the twist maze of xc_map_foreign_* by one, which will be > useful when trying to come up with an underlying stable interface. > > NetBSD and Solaris implemented xc_map_foreign_bulk in terms of > xc_map_foreign_batch via a compat layer, so xc_map_foreign_batch > becomes an internal osdep for them. New OS ports should always > implement xc_map_foreign_bulk instead. > > Signed-off-by: Ian Campbell > Cc: George Dunlap Acked-by: Wei Liu