From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Florian Westphal <fw@strlen.de>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH v4 nf-next 2/2] netfilter: nf_tables: wrap tracing with a static key
Date: Wed, 9 Dec 2015 13:22:20 +0100 [thread overview]
Message-ID: <20151209122220.GB2185@salvia> (raw)
In-Reply-To: <1448743985-21685-2-git-send-email-fw@strlen.de>
On Sat, Nov 28, 2015 at 09:53:05PM +0100, Florian Westphal wrote:
> Only needed when meta nftrace rule(s) were added.
> The assumption is that no such rules are active, so the call to
> nft_trace_init is "never" needed.
>
> When nftrace rules are active, we always call the nft_trace_* functions,
> but will only send netlink messages when all of the following are true:
>
> - traceinfo structure was initialised
> - skb->nf_trace == 1
> - at least one subscriber to trace group.
>
> Adding an extra conditional
> (static_branch ... && skb->nf_trace)
> nft_trace_init( ..)
>
> Is possible but results in a larger nft_do_chain footprint.
Also applied, thanks.
next prev parent reply other threads:[~2015-12-09 12:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-28 20:53 [PATCH v4 nf-next 1/2] netfilter: nf_tables: extend tracing infrastructure Florian Westphal
2015-11-28 20:53 ` [PATCH v4 nf-next 2/2] netfilter: nf_tables: wrap tracing with a static key Florian Westphal
2015-12-09 12:22 ` Pablo Neira Ayuso [this message]
2015-12-09 12:22 ` [PATCH v4 nf-next 1/2] netfilter: nf_tables: extend tracing infrastructure Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151209122220.GB2185@salvia \
--to=pablo@netfilter.org \
--cc=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.