From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wei Liu Subject: Re: [PATCH XEN v6 21/32] tools/libs/foreignmemory: pull array length argument to map forward Date: Wed, 9 Dec 2015 12:22:24 +0000 Message-ID: <20151209122224.GI23818@citrix.com> References: <1449141675.4424.125.camel@citrix.com> <1449141749-14940-1-git-send-email-ian.campbell@citrix.com> <1449141749-14940-22-git-send-email-ian.campbell@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <1449141749-14940-22-git-send-email-ian.campbell@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: wei.liu2@citrix.com, ian.jackson@eu.citrix.com, xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On Thu, Dec 03, 2015 at 11:22:18AM +0000, Ian Campbell wrote: > By having the "num" argument before the page and error arrays we can > potentially use a variable-length-array argument ("int pages[num]") in > the function prototype. > > However VLAs are a C99 feature and we are currently targetting C89 and > later, so we don't actually make use of this here, merely arrange that > we can switch to VLAs in the future without changing the function ABI. > > Signed-off-by: Ian Campbell Acked-by: Wei Liu