From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pablo Neira Ayuso Subject: Re: [PATCH nf-next] netfilter: nftables: Change the return type of nfulnl_set_timeout() and nfulnl_set_qthresh() to be void. Date: Wed, 9 Dec 2015 15:00:44 +0100 Message-ID: <20151209140044.GA1568@salvia> References: <1449576564-30233-1-git-send-email-rami.rosen@intel.com> <20151209135158.GA1309@salvia> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: kadlec@blackhole.kfki.hu, netfilter-devel@vger.kernel.org, coreteam@netfilter.org To: Rami Rosen Return-path: Received: from mail.us.es ([193.147.175.20]:42315 "EHLO mail.us.es" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754800AbbLIOAs (ORCPT ); Wed, 9 Dec 2015 09:00:48 -0500 Received: from antivirus1-rhel7.int (unknown [192.168.2.11]) by mail.us.es (Postfix) with ESMTP id 93C111324D0 for ; Wed, 9 Dec 2015 15:00:47 +0100 (CET) Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id 813B5DA809 for ; Wed, 9 Dec 2015 15:00:47 +0100 (CET) Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id A06F1DA81D for ; Wed, 9 Dec 2015 15:00:45 +0100 (CET) Content-Disposition: inline In-Reply-To: <20151209135158.GA1309@salvia> Sender: netfilter-devel-owner@vger.kernel.org List-ID: On Wed, Dec 09, 2015 at 02:51:58PM +0100, Pablo Neira Ayuso wrote: > On Tue, Dec 08, 2015 at 07:09:24AM -0500, Rami Rosen wrote: > > This patch changes the return type of the static methods nfulnl_set_timeout() and > > nfulnl_set_qthresh() to be void, as there is no justification and no need for these methods to return int. > > Applied, thanks. For the record, I have renamed the title to: "netfilter: nfnetlink_log: Change setter functions to be void" This is not related to nftables itself, but our userspace logging infrastructure. Then I have trimmed off the title length a bit, I hope this retains the original spirit of it.