From: Andrew Lunn <andrew@lunn.ch>
To: Paul Gortmaker <paul.gortmaker@windriver.com>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>,
Michael Ellerman <mpe@ellerman.id.au>,
netdev@vger.kernel.org, linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH] sbc8641: drop bogus PHY IRQ entries from DTS file
Date: Wed, 9 Dec 2015 16:29:23 +0100 [thread overview]
Message-ID: <20151209152923.GL13328@lunn.ch> (raw)
In-Reply-To: <20151209143951.GM22885@windriver.com>
> > Originally the interrupt is used for detecting the link has gone
> > down. That would of also been bogus before. Have you tried this? If
>
> Haven't tried it, but chances are you are right.
>
> > that is also broken, maybe you need to add a fixes: tag so that it
> > gets back ported?
>
> Nobody noticed in the past ~7 years or so, but I guess I can point Greg
> at it once it is present in mainline. The main reason I'd Cc'd netdev
> is just to possibly save anyone else the investigation if they ran into
> the same issue on a different board -which seems highly probable IMHO.
Yes, you are probably right about other boards. So this change might
be considered as causing a regression. But if they are already broken,
because link down does not work, there might be less demand to get the
change reverted....
Andrew
next prev parent reply other threads:[~2015-12-09 15:29 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-08 22:44 [PATCH] sbc8641: drop bogus PHY IRQ entries from DTS file Paul Gortmaker
2015-12-09 1:10 ` Michael Ellerman
2015-12-09 2:04 ` Paul Gortmaker
2015-12-09 3:04 ` Michael Ellerman
2015-12-09 2:40 ` David Miller
2015-12-09 3:00 ` Michael Ellerman
2015-12-09 3:07 ` Andrew Lunn
2015-12-09 14:39 ` Paul Gortmaker
2015-12-09 15:29 ` Andrew Lunn [this message]
2015-12-14 9:46 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151209152923.GL13328@lunn.ch \
--to=andrew@lunn.ch \
--cc=benh@kernel.crashing.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=netdev@vger.kernel.org \
--cc=paul.gortmaker@windriver.com \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.