From: Christoph Hellwig <hch@infradead.org>
To: Sagi Grimberg <sagig@mellanox.com>
Cc: linux-rdma@vger.kernel.org, target-devel@vger.kernel.org,
Or Gerlitz <ogerlitz@mellanox.com>,
Jenny Derzhavetz <jennyf@mellanox.com>,
"Nicholas A. Bellinger" <nab@linux-iscsi.org>
Subject: Re: [PATCH v2 05/10] iser: Have initiator and target to share protocol structures and definitions
Date: Wed, 9 Dec 2015 11:33:50 -0800 [thread overview]
Message-ID: <20151209193350.GD21477@infradead.org> (raw)
In-Reply-To: <1449663128-368-6-git-send-email-sagig@mellanox.com>
> -/* Constant PDU lengths calculations */
> -#define ISER_HEADERS_LEN (sizeof(struct iser_hdr) + sizeof(struct iscsi_hdr))
> +/*Constant PDU lengths calculations */
Odd whitespace error.
Otherwise looks fine:
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2015-12-09 19:33 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-09 12:11 [PATCH v2 00/10] iSER support for remote invalidate Sagi Grimberg
2015-12-09 12:12 ` [PATCH v2 02/10] IB/iser: Reuse ib_sg_to_pages Sagi Grimberg
2015-12-09 19:28 ` Christoph Hellwig
[not found] ` <20151209192819.GA21477-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
2015-12-10 8:28 ` Sagi Grimberg
2015-12-10 14:49 ` Christoph Hellwig
2015-12-09 12:12 ` [PATCH v2 03/10] IB/iser: Don't register memory for all immediate data writes Sagi Grimberg
2015-12-09 19:30 ` Christoph Hellwig
2015-12-10 8:31 ` Sagi Grimberg
2015-12-09 12:12 ` [PATCH v2 04/10] IB/iser: set intuitive values for mr_valid Sagi Grimberg
2015-12-09 19:32 ` Christoph Hellwig
[not found] ` <1449663128-368-1-git-send-email-sagig-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2015-12-09 12:11 ` [PATCH v2 01/10] IB/iser: Fix module init not cleaning up on error flow Sagi Grimberg
2015-12-09 12:12 ` [PATCH v2 05/10] iser: Have initiator and target to share protocol structures and definitions Sagi Grimberg
2015-12-09 19:33 ` Christoph Hellwig [this message]
2015-12-09 12:12 ` [PATCH v2 06/10] iser-target: Remove unused file iser_proto.h Sagi Grimberg
2015-12-09 12:12 ` [PATCH v2 07/10] iser-target: Declare correct flags when accepting a connection Sagi Grimberg
[not found] ` <1449663128-368-8-git-send-email-sagig-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2015-12-09 19:36 ` Christoph Hellwig
[not found] ` <20151209193614.GE21477-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
2015-12-10 8:33 ` Sagi Grimberg
2015-12-09 12:12 ` [PATCH v2 08/10] iser-target: Support the remote invalidation exception Sagi Grimberg
[not found] ` <1449663128-368-9-git-send-email-sagig-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2015-12-09 19:37 ` Christoph Hellwig
2015-12-09 12:12 ` [PATCH v2 09/10] IB/iser: Increment the rkey when registering and not when invalidating Sagi Grimberg
2015-12-09 19:38 ` Christoph Hellwig
2015-12-09 12:12 ` [PATCH v2 10/10] IB/iser: Support the remote invalidation exception Sagi Grimberg
2015-12-21 4:20 ` [PATCH v2 00/10] iSER support for remote invalidate Nicholas A. Bellinger
[not found] ` <1450671628.25674.27.camel-XoQW25Eq2zviZyQQd+hFbcojREIfoBdhmpATvIKMPHk@public.gmane.org>
2015-12-21 11:53 ` Or Gerlitz
[not found] ` <CAJ3xEMi58s6bWv7cyb+3v3H7e=4t6hRaOX0TvTyXRXLiUjxq+g-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-12-21 13:29 ` Sagi Grimberg
[not found] ` <5677FEBB.7080904-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
2015-12-23 20:53 ` Or Gerlitz
2016-01-04 6:38 ` Or Gerlitz
2015-12-21 13:27 ` Sagi Grimberg
2015-12-24 10:15 ` Christoph Hellwig
[not found] ` <20151224101514.GB6438-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
2015-12-24 10:22 ` Sagi Grimberg
[not found] ` <567BC782.7090501-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
2016-01-06 18:43 ` Nicholas A. Bellinger
2016-01-07 15:26 ` Sagi Grimberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151209193350.GD21477@infradead.org \
--to=hch@infradead.org \
--cc=jennyf@mellanox.com \
--cc=linux-rdma@vger.kernel.org \
--cc=nab@linux-iscsi.org \
--cc=ogerlitz@mellanox.com \
--cc=sagig@mellanox.com \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.