From: Michael Welling <mwelling@ieee.org>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: linux-gpio@vger.kernel.org, Johan Hovold <johan@kernel.org>,
Alexandre Courbot <acourbot@nvidia.com>,
Markus Pargmann <mpa@pengutronix.de>,
Anatolij Gustschin <agust@denx.de>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>,
Michael Ellerman <mpe@ellerman.id.au>
Subject: Re: [PATCH 143/182] powerpc: mpc52xx_gpt: use gpiochip data pointer
Date: Wed, 9 Dec 2015 17:27:46 -0600 [thread overview]
Message-ID: <20151209232746.GC28304@deathstar> (raw)
In-Reply-To: <1449668466-4882-1-git-send-email-linus.walleij@linaro.org>
On Wed, Dec 09, 2015 at 02:41:06PM +0100, Linus Walleij wrote:
> @@ -354,7 +349,7 @@ mpc52xx_gpt_gpio_setup(struct mpc52xx_gpt_priv *gpt, struct device_node *node)
> clrsetbits_be32(&gpt->regs->mode, MPC52xx_GPT_MODE_MS_MASK,
> MPC52xx_GPT_MODE_MS_GPIO);
>
> - rc = gpiochip_add(&gpt->gc);
> + rc = gpiochip_add_data(&gpt->gc, gpt);
> if (rc)
Another place that dev_err references gpiochip_add instead of gpiochip_add_data.
> dev_err(gpt->dev, "gpiochip_add() failed; rc=%i\n", rc);
>
Other places with references not associated with patches:
Documentation/zh_CN/gpio.txt
Documentation/gpio/gpio-legacy.txt
Documentation/gpio/driver.txt
next prev parent reply other threads:[~2015-12-09 23:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-09 13:41 [PATCH 143/182] powerpc: mpc52xx_gpt: use gpiochip data pointer Linus Walleij
2015-12-09 23:27 ` Michael Welling [this message]
2015-12-13 21:02 ` Linus Walleij
2015-12-13 23:01 ` Michael Welling
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151209232746.GC28304@deathstar \
--to=mwelling@ieee.org \
--cc=acourbot@nvidia.com \
--cc=agust@denx.de \
--cc=benh@kernel.crashing.org \
--cc=johan@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=mpa@pengutronix.de \
--cc=mpe@ellerman.id.au \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.