From: Michael Welling <mwelling@ieee.org>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: linux-gpio@vger.kernel.org, Johan Hovold <johan@kernel.org>,
Alexandre Courbot <acourbot@nvidia.com>,
Markus Pargmann <mpa@pengutronix.de>,
Michael Hennerich <michael.hennerich@analog.com>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>
Subject: Re: [PATCH 156/182] input: adp5589-keys: use gpiochip data pointer
Date: Wed, 9 Dec 2015 17:47:52 -0600 [thread overview]
Message-ID: <20151209234752.GB8146@deathstar> (raw)
In-Reply-To: <1449668710-5785-1-git-send-email-linus.walleij@linaro.org>
On Wed, Dec 09, 2015 at 02:45:10PM +0100, Linus Walleij wrote:
> @@ -525,7 +525,7 @@ static int adp5589_gpio_add(struct adp5589_kpad *kpad)
>
> mutex_init(&kpad->gpio_lock);
>
> - error = gpiochip_add(&kpad->gc);
> + error = gpiochip_add_data(&kpad->gc, kpad);
> if (error) {
> dev_err(dev, "gpiochip_add failed, err: %d\n", error);
Another dev_err referencing gpiochip_add instead of gpiochip_add_data.
> return error;
> --
> 2.4.3
>
next prev parent reply other threads:[~2015-12-09 23:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-09 13:45 [PATCH 156/182] input: adp5589-keys: use gpiochip data pointer Linus Walleij
2015-12-09 13:43 ` Michael Hennerich
2015-12-09 13:43 ` Michael Hennerich
2015-12-09 23:47 ` Michael Welling [this message]
2015-12-13 21:00 ` Linus Walleij
2015-12-16 22:07 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151209234752.GB8146@deathstar \
--to=mwelling@ieee.org \
--cc=acourbot@nvidia.com \
--cc=dmitry.torokhov@gmail.com \
--cc=johan@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=michael.hennerich@analog.com \
--cc=mpa@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.