From: Stephen Hemminger <stephen@networkplumber.org>
To: Nicolas Dichtel <nicolas.dichtel@6wind.com>
Cc: shemminger@vyatta.com, netdev@vger.kernel.org
Subject: Re: [PATCH iproute2] libnetlink: don't confuse variables in rtnl_talk()
Date: Thu, 10 Dec 2015 08:49:29 -0800 [thread overview]
Message-ID: <20151210084929.33fa7bcf@xeon-e3> (raw)
In-Reply-To: <1449159228-4233-1-git-send-email-nicolas.dichtel@6wind.com>
On Thu, 3 Dec 2015 17:13:48 +0100
Nicolas Dichtel <nicolas.dichtel@6wind.com> wrote:
> There is two variables named 'len' in rtnl_talk. In fact, commit
> c079e121a73a didn't work. For example, it was possible to trigger
> a seg fault with this command:
> $ ip link set gre2 type ip6gre hoplimit 32
>
> Let's rename the argument len to maxlen.
>
> Fixes: c079e121a73a ("libnetlink: add size argument to rtnl_talk")
> Reported-by: Thomas Faivre <thomas.faivre@6wind.com>
> Signed-off-by: Nicolas Dichtel <nicolas.dichtel@6wind.com>
Applied, thanks, Not sure why compiler isn't catching this.
prev parent reply other threads:[~2015-12-10 16:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-03 16:13 [PATCH iproute2] libnetlink: don't confuse variables in rtnl_talk() Nicolas Dichtel
2015-12-10 16:49 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151210084929.33fa7bcf@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=netdev@vger.kernel.org \
--cc=nicolas.dichtel@6wind.com \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.