From: Lee Jones <lee.jones@linaro.org>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: linux-gpio@vger.kernel.org, Johan Hovold <johan@kernel.org>,
Alexandre Courbot <acourbot@nvidia.com>,
Michael Welling <mwelling@ieee.org>,
Markus Pargmann <mpa@pengutronix.de>,
Philipp Zabel <philipp.zabel@gmail.com>
Subject: Re: [PATCH 163/182] mfd: htc-egpio: use gpiochip data pointer
Date: Thu, 10 Dec 2015 10:33:53 +0000 [thread overview]
Message-ID: <20151210103353.GG17876@x1> (raw)
In-Reply-To: <1449668857-6260-1-git-send-email-linus.walleij@linaro.org>
On Wed, 09 Dec 2015, Linus Walleij wrote:
> This makes the driver use the data pointer added to the gpio_chip
> to store a pointer to the state container instead of relying on
> container_of().
>
> Cc: Lee Jones <lee.jones@linaro.org>
> Cc: Philipp Zabel <philipp.zabel@gmail.com>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> ---
> Lee please ACK this so I can take it through the GPIO tree.
> Philipp: should this driver move to drivers/gpio? Looks like
> so to me.
> ---
> drivers/mfd/htc-egpio.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
Acked-by: Lee Jones <lee.jones@linaro.org>
> diff --git a/drivers/mfd/htc-egpio.c b/drivers/mfd/htc-egpio.c
> index d334e7d8a77d..2e066fe66ca7 100644
> --- a/drivers/mfd/htc-egpio.c
> +++ b/drivers/mfd/htc-egpio.c
> @@ -155,7 +155,7 @@ static int egpio_get(struct gpio_chip *chip, unsigned offset)
>
> pr_debug("egpio_get_value(%d)\n", chip->base + offset);
>
> - egpio = container_of(chip, struct egpio_chip, chip);
> + egpio = gpiochip_get_data(chip);
> ei = dev_get_drvdata(egpio->dev);
> bit = egpio_bit(ei, offset);
> reg = egpio->reg_start + egpio_pos(ei, offset);
> @@ -170,7 +170,7 @@ static int egpio_direction_input(struct gpio_chip *chip, unsigned offset)
> {
> struct egpio_chip *egpio;
>
> - egpio = container_of(chip, struct egpio_chip, chip);
> + egpio = gpiochip_get_data(chip);
> return test_bit(offset, &egpio->is_out) ? -EINVAL : 0;
> }
>
> @@ -192,7 +192,7 @@ static void egpio_set(struct gpio_chip *chip, unsigned offset, int value)
> pr_debug("egpio_set(%s, %d(%d), %d)\n",
> chip->label, offset, offset+chip->base, value);
>
> - egpio = container_of(chip, struct egpio_chip, chip);
> + egpio = gpiochip_get_data(chip);
> ei = dev_get_drvdata(egpio->dev);
> bit = egpio_bit(ei, offset);
> pos = egpio_pos(ei, offset);
> @@ -216,7 +216,7 @@ static int egpio_direction_output(struct gpio_chip *chip,
> {
> struct egpio_chip *egpio;
>
> - egpio = container_of(chip, struct egpio_chip, chip);
> + egpio = gpiochip_get_data(chip);
> if (test_bit(offset, &egpio->is_out)) {
> egpio_set(chip, offset, value);
> return 0;
> @@ -330,7 +330,7 @@ static int __init egpio_probe(struct platform_device *pdev)
> chip->base = pdata->chip[i].gpio_base;
> chip->ngpio = pdata->chip[i].num_gpios;
>
> - gpiochip_add(chip);
> + gpiochip_add_data(chip, &ei->chip[i]);
> }
>
> /* Set initial pin values */
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2015-12-10 10:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-09 13:47 [PATCH 163/182] mfd: htc-egpio: use gpiochip data pointer Linus Walleij
2015-12-09 18:21 ` Philipp Zabel
2015-12-10 10:33 ` Lee Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151210103353.GG17876@x1 \
--to=lee.jones@linaro.org \
--cc=acourbot@nvidia.com \
--cc=johan@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=mpa@pengutronix.de \
--cc=mwelling@ieee.org \
--cc=philipp.zabel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.