All of lore.kernel.org
 help / color / mirror / Atom feed
From: mark.rutland@arm.com (Mark Rutland)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC PATCH 04/20] arm64: mm: assume PAGE SIZE for page table allocator
Date: Thu, 10 Dec 2015 14:23:45 +0000	[thread overview]
Message-ID: <20151210142344.GA495@leverpostej> (raw)
In-Reply-To: <20151210140840.GE21134@arm.com>

On Thu, Dec 10, 2015 at 02:08:40PM +0000, Will Deacon wrote:
> On Wed, Dec 09, 2015 at 12:44:39PM +0000, Mark Rutland wrote:
> > We pass a size parameter to early_alloc and late_alloc, but these are
> > only ever used to allocate single pages. In late_alloc we always
> > allocate a single page.
> > 
> > Remove the redundant size parameter.
> > 
> > Signed-off-by: Mark Rutland <mark.rutland@arm.com>
> > Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> > Cc: Catalin Marinas <catalin.marinas@arm.com>
> > Cc: Jeremy Linton <jeremy.linton@arm.com>
> > Cc: Laura Abbott <labbott@fedoraproject.org>
> > Cc: Will Deacon <will.deacon@arm.com>
> > ---
> >  arch/arm64/mm/mmu.c | 27 ++++++++++++---------------
> >  1 file changed, 12 insertions(+), 15 deletions(-)
> 
> Looks sensible to me. Cosmetic nit, but we could we rename these to
> early_page_alloc/late_page_alloc instead, please?

Sure. I'll also s/alloc/page_alloc/ for the function pointer. Luckily
this doesn't clash with the usual alloc_page function.

I'll also fix up the zero page init, as I forgot to remove the PAGE_SIZE
parameter in that early_alloc() call there.

Thanks,
Mark.

  reply	other threads:[~2015-12-10 14:23 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-09 12:44 [RFC PATCH 00/20] arm64: mm: rework page table creation Mark Rutland
2015-12-09 12:44 ` [RFC PATCH 01/20] arm64: mm: remove pointless PAGE_MASKing Mark Rutland
2015-12-09 12:44 ` [RFC PATCH 02/20] arm64: Remove redundant padding from linker script Mark Rutland
2015-12-09 12:44 ` [RFC PATCH 03/20] arm64: mm: fold alternatives into .init Mark Rutland
2015-12-09 12:44 ` [RFC PATCH 04/20] arm64: mm: assume PAGE SIZE for page table allocator Mark Rutland
2015-12-10 14:08   ` Will Deacon
2015-12-10 14:23     ` Mark Rutland [this message]
2015-12-09 12:44 ` [RFC PATCH 05/20] asm-generic: make __set_fixmap_offset a static inline Mark Rutland
2015-12-09 12:44 ` [RFC PATCH 06/20] arm64: mm: place empty_zero_page in bss Mark Rutland
2015-12-10 14:11   ` Will Deacon
2015-12-10 15:29     ` Mark Rutland
2015-12-10 15:40       ` Marc Zyngier
2015-12-10 15:51         ` Mark Rutland
2015-12-10 16:01           ` Marc Zyngier
2015-12-09 12:44 ` [RFC PATCH 07/20] arm64: unify idmap removal Mark Rutland
2015-12-09 12:44 ` [RFC PATCH 08/20] arm64: unmap idmap earlier Mark Rutland
2015-12-09 12:44 ` [RFC PATCH 09/20] arm64: add function to install the idmap Mark Rutland
2015-12-09 12:44 ` [RFC PATCH 10/20] arm64: mm: add code to safely replace TTBR1_EL1 Mark Rutland
2015-12-09 12:44 ` [RFC PATCH 11/20] arm64: mm: move pte_* macros Mark Rutland
2015-12-09 12:44 ` [RFC PATCH 12/20] arm64: mm: add functions to walk page tables by PA Mark Rutland
2015-12-09 12:44 ` [RFC PATCH 13/20] arm64: mm: avoid redundant __pa(__va(x)) Mark Rutland
2015-12-09 12:44 ` [RFC PATCH 14/20] arm64: mm: add __{pud,pgd}_populate Mark Rutland
2015-12-09 12:44 ` [RFC PATCH 15/20] arm64: mm: add functions to walk tables in fixmap Mark Rutland
2015-12-09 12:44 ` [RFC PATCH 16/20] arm64: mm: use fixmap when creating page tables Mark Rutland
2015-12-09 12:44 ` [RFC PATCH 17/20] arm64: mm: allocate pagetables anywhere Mark Rutland
2015-12-09 12:44 ` [RFC PATCH 18/20] arm64: mm: allow passing a pgdir to alloc_init_* Mark Rutland
2015-12-09 12:44 ` [RFC PATCH 19/20] arm64: ensure _stext and _etext are page-aligned Mark Rutland
2015-12-09 12:44 ` [RFC PATCH 20/20] arm64: mm: create new fine-grained mappings at boot Mark Rutland

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151210142344.GA495@leverpostej \
    --to=mark.rutland@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.