All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] usb: host: ehci: samsung: Move hcor initialization after usb phy setup
Date: Thu, 10 Dec 2015 17:20:50 +0100	[thread overview]
Message-ID: <201512101720.50937.marex@denx.de> (raw)
In-Reply-To: <1449761545-4824-1-git-send-email-l.majewski@samsung.com>

On Thursday, December 10, 2015 at 04:32:25 PM, Lukasz Majewski wrote:
> With the old order of initialization the hcor pointer has been setup to
> the same address as Exynos EHCI base address (0x12110000 instead of
> 0x12110010).
> Such behaviour was caused by reading value of 0 instead of 0x10 from EHCI
> HCCPBASE register without doing proper clock initialization before.
> 
> To fix this problem hcor initialization has been moved after USB PHY setup.
> Now ehci_readl(&ctx->hcd->cr_capbase) returns correct value.
> 
> Signed-off-by: Lukasz Majewski <l.majewski@samsung.com>
> ---
>  drivers/usb/host/ehci-exynos.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/usb/host/ehci-exynos.c
> b/drivers/usb/host/ehci-exynos.c index 18e9251..bede04b 100644
> --- a/drivers/usb/host/ehci-exynos.c
> +++ b/drivers/usb/host/ehci-exynos.c
> @@ -219,14 +219,14 @@ static int ehci_usb_probe(struct udevice *dev)
> 
>  	ctx->hcd = (struct ehci_hccr *)plat->hcd_base;
>  	ctx->usb = (struct exynos_usb_phy *)plat->phy_base;
> -	hcor = (struct ehci_hcor *)((uint32_t)ctx->hcd +
> -			HC_LENGTH(ehci_readl(&ctx->hcd->cr_capbase)));
> 
>  	/* setup the Vbus gpio here */
>  	if (dm_gpio_is_valid(&plat->vbus_gpio))
>  		dm_gpio_set_value(&plat->vbus_gpio, 1);
> 
>  	setup_usb_phy(ctx->usb);
> +	hcor = (struct ehci_hcor *)((uint32_t)ctx->hcd +
> +			HC_LENGTH(ehci_readl(&ctx->hcd->cr_capbase)));

Acked-by: Marek Vasut <marex@denx.de>

Best regards,
Marek Vasut

  reply	other threads:[~2015-12-10 16:20 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-10 15:32 [U-Boot] [PATCH] usb: host: ehci: samsung: Move hcor initialization after usb phy setup Lukasz Majewski
2015-12-10 16:20 ` Marek Vasut [this message]
2015-12-10 17:39 ` Simon Glass

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201512101720.50937.marex@denx.de \
    --to=marex@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.