From mboxrd@z Thu Jan 1 00:00:00 1970 From: Leon Romanovsky Subject: Re: [PATCH 03/37] IB/rdmavt: Add protection domain to rdmavt. Date: Thu, 10 Dec 2015 19:54:53 +0200 Message-ID: <20151210175453.GE8662@leon.nu> References: <20151207204046.8144.18752.stgit@phlsvslse11.ph.intel.com> <20151207204309.8144.26707.stgit@phlsvslse11.ph.intel.com> <20151208062816.GE7313@leon.nu> <20151210164047.GB13412@phlsvsds.ph.intel.com> Reply-To: leon-2ukJVAZIZ/Y@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20151210164047.GB13412-W4f6Xiosr+yv7QzWx2u06xL4W9x8LtSr@public.gmane.org> Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Dennis Dalessandro Cc: dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Mike Marciniszyn , Ira Weiny List-Id: linux-rdma@vger.kernel.org On Thu, Dec 10, 2015 at 11:40:48AM -0500, Dennis Dalessandro wrote: > On Tue, Dec 08, 2015 at 08:28:17AM +0200, Leon Romanovsky wrote: > >On Mon, Dec 07, 2015 at 03:43:10PM -0500, Dennis Dalessandro wrote: > >>+ > >>+/* > >>+ * Things that are driver specific, module parameters in hfi1 and qib > >>+ */ > >>+struct rvt_driver_params { > >>+ int max_pds; > >Can it be negative value? > >>+}; > > If so no protection domains would ever get allocated. I don't think anything > else would break though if a driver were to do that. In such way, it should be "unsigned int". > > -Denny > -- > To unsubscribe from this list: send the line "unsubscribe linux-rdma" in > the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html