From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
To: Jandy Gou <qingsong.gou@ck-telecom.com>
Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
rickard_strandqvist@spectrumdigital.se,
linux-kernel@vger.kernel.org, cristina.opriceana@gmail.com
Subject: Re: [PATCH] Staging:rtl8192u: fixes the following sparse warning:
Date: Fri, 11 Dec 2015 12:21:22 +0530 [thread overview]
Message-ID: <20151211065122.GC4763@sudip-pc> (raw)
In-Reply-To: <1449813131-25459-1-git-send-email-qingsong.gou@ck-telecom.com>
On Fri, Dec 11, 2015 at 01:52:11PM +0800, Jandy Gou wrote:
> drivers/staging/rtl8192u/r8192U_core.c:3212:6: warning: symbol
> 'rtl819x_watchdog_wqcallback' was not declared. Should it be static?
> drivers/staging/rtl8192u/r8192U_core.c:3276:6: warning: symbol
> 'watch_dog_timer_callback' was not declared. Should it be static?
> drivers/staging/rtl8192u/r8192U_core.c:3282:5: warning: symbol
> '_rtl8192_up' was not declared. Should it be static?
> drivers/staging/rtl8192u/r8192U_core.c:3333:5: warning: symbol
> 'rtl8192_close' was not declared. Should it be static?
> drivers/staging/rtl8192u/r8192U_core.c:3406:6: warning: symbol
> 'rtl8192_restart' was not declared. Should it be static?
> drivers/staging/rtl8192u/r8192U_core.c:4618:6: warning: symbol
> 'rtl8192_irq_rx_tasklet' was not declared. Should it be static?
> drivers/staging/rtl8192u/r8192U_core.c:4736:6: warning: symbol
> 'rtl8192_cancel_deferred_work' was not declared. Should it be static?
>
> Signed-off-by: Jandy Gou <qingsong.gou@ck-telecom.com>
> ---
This has already been done by commit:
bdc01d5711b3 ("staging: rtl8192u: Make core functions static")
And the commit date shows April.
Which tree are you using?
regards
sudip
prev parent reply other threads:[~2015-12-11 6:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-11 5:52 [PATCH] Staging:rtl8192u: fixes the following sparse warning: Jandy Gou
2015-12-11 6:51 ` Sudip Mukherjee [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151211065122.GC4763@sudip-pc \
--to=sudipm.mukherjee@gmail.com \
--cc=cristina.opriceana@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=qingsong.gou@ck-telecom.com \
--cc=rickard_strandqvist@spectrumdigital.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.