All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johan Hovold <johan@kernel.org>
To: "Geyslan G. Bem" <geyslan@gmail.com>
Cc: peter.senna@gmail.com, Johan Hovold <johan@kernel.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/4] usb: serial: remove redundant conditions
Date: Fri, 11 Dec 2015 10:16:32 +0100	[thread overview]
Message-ID: <20151211091632.GH28650@localhost> (raw)
In-Reply-To: <1449780614-5933-1-git-send-email-geyslan@gmail.com>

On Thu, Dec 10, 2015 at 05:50:09PM -0300, Geyslan G. Bem wrote:
> This patch removes redundant conditions.
> 
>  (!A || (A && B)) is the same as (!A || B).
>  (length && length > 5) can be reduced to a single evaluation.
> 
> Tested by compilation only.
> Caught by cppcheck.
> 
> Signed-off-by: Geyslan G. Bem <geyslan@gmail.com>
> ---
>  drivers/usb/serial/io_edgeport.c | 35 ++++++++++++++---------------------
>  drivers/usb/serial/mos7840.c     |  2 +-
>  2 files changed, 15 insertions(+), 22 deletions(-)

Please split this up per driver as I (and Felipe) asked.

You can send these two separate from the rest, and remember to CC
the USB list.

Thanks,
Johan

  parent reply	other threads:[~2015-12-11  9:16 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-10 20:50 [PATCH 1/4] usb: serial: remove redundant conditions Geyslan G. Bem
2015-12-10 20:50 ` [PATCH 2/4] usb: gadget: remove redundant condition Geyslan G. Bem
2015-12-10 20:50 ` [PATCH 3/4] usb: host: " Geyslan G. Bem
2015-12-10 20:50 ` [PATCH 4/4] usb: musb: " Geyslan G. Bem
2015-12-11  9:16 ` Johan Hovold [this message]
2015-12-11  9:35   ` [PATCH 1/4] usb: serial: remove redundant conditions Geyslan G. Bem

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151211091632.GH28650@localhost \
    --to=johan@kernel.org \
    --cc=geyslan@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=peter.senna@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.