From: Andrew Morton <akpm@linux-foundation.org>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: heikki.krogerus@linux.intel.com, kevin@scrye.com,
mika.westerberg@linux.intel.com, rafael.j.wysocki@intel.com,
mm-commits@vger.kernel.org
Subject: Re: + include-linux-propertyh-fix-build-issues-with-gcc-444.patch added to -mm tree
Date: Fri, 11 Dec 2015 09:58:08 -0800 [thread overview]
Message-ID: <20151211095808.82df2854.akpm@linux-foundation.org> (raw)
In-Reply-To: <1449830574.30729.106.camel@linux.intel.com>
On Fri, 11 Dec 2015 12:42:54 +0200 Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
> > __#define PROPERTY_ENTRY_INTEGER_ARRAY(_name_, _type_, _val_) \
> > __{ \
> > __ .name = _name_,
> > \
> > __ .length = ARRAY_SIZE(_val_) * sizeof(_type_),
> > \
> > __ .is_array = true, \
> > - .pointer._type_##_data = _val_,
> > \
> > + .is_string = false, \
> > + { .pointer = _type_##_data = _val_ } },
>
> This line looks suspicious now. Shouldn't be
>
> { .pointer = { ._type_##_data = _val_ } },
yup, thanks. Stupid macros.
It tooks me ages to work out this workaround. The secret is to have
the immediately preceding field (is_string) explicitly menationed.
prev parent reply other threads:[~2015-12-11 17:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-11 0:54 + include-linux-propertyh-fix-build-issues-with-gcc-444.patch added to -mm tree akpm
[not found] ` <1449830574.30729.106.camel@linux.intel.com>
2015-12-11 17:58 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151211095808.82df2854.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=heikki.krogerus@linux.intel.com \
--cc=kevin@scrye.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=mm-commits@vger.kernel.org \
--cc=rafael.j.wysocki@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.