From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753724AbbLKOCJ (ORCPT ); Fri, 11 Dec 2015 09:02:09 -0500 Received: from bombadil.infradead.org ([198.137.202.9]:46976 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752463AbbLKOCI (ORCPT ); Fri, 11 Dec 2015 09:02:08 -0500 Date: Fri, 11 Dec 2015 15:02:01 +0100 From: Peter Zijlstra To: Alexander Shishkin Cc: Ingo Molnar , linux-kernel@vger.kernel.org, vince@deater.net, eranian@google.com, Arnaldo Carvalho de Melo , Mathieu Poirier , mark.rutland@arm.com Subject: Re: [PATCH v0 3/5] perf: Introduce instruction trace filtering Message-ID: <20151211140201.GQ6356@twins.programming.kicks-ass.net> References: <1449840998-29902-1-git-send-email-alexander.shishkin@linux.intel.com> <1449840998-29902-4-git-send-email-alexander.shishkin@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1449840998-29902-4-git-send-email-alexander.shishkin@linux.intel.com> User-Agent: Mutt/1.5.21 (2012-12-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Dec 11, 2015 at 03:36:36PM +0200, Alexander Shishkin wrote: > The pmu driver interface basically adds an extra callback to the > pmu driver structure, which validates the filter configuration proposed > by the user against what the hardware is actually capable of doing > and translates it into something that pmu::start can program into > hardware. > @@ -388,12 +393,38 @@ struct pmu { > void (*free_aux) (void *aux); /* optional */ > > /* > + * Validate instruction tracing filters: make sure hw supports the > + * requested configuration and number of filters. > + * > + * Configure instruction tracing filters: translate hw-agnostic filter > + * into hardware configuration in event::hw::itrace_filters > + */ > + int (*itrace_filter_setup) (struct perf_event *event); /* optional */ > + > + /* > * Filter events for PMU-specific reasons. > */ > int (*filter_match) (struct perf_event *event); /* optional */ > }; Any reason you cannot use pmu::filter_match ?