From: Al Viro <viro@ZenIV.linux.org.uk>
To: David Eccher <d.eccher@gmail.com>
Cc: Felipe Balbi <balbi@ti.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] USB: inode.c: fix unbalanced spin_lock in ep0_write
Date: Fri, 11 Dec 2015 20:11:15 +0000 [thread overview]
Message-ID: <20151211201115.GK20997@ZenIV.linux.org.uk> (raw)
In-Reply-To: <1449863786-7697-1-git-send-email-d.eccher@gmail.com>
On Fri, Dec 11, 2015 at 08:56:26PM +0100, David Eccher wrote:
> Fix bad unlock balance: ep0_write enter with the locks locked from inode.c:1769,
> hence it must exit with spinlock held to avoid double unlock in dev_config.
*Ugh*
Just take that spinlock before the if (retval < 0) and don't drop it after
clear_req(), then...
next prev parent reply other threads:[~2015-12-11 20:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-11 19:56 [PATCH 1/1] USB: inode.c: fix unbalanced spin_lock in ep0_write David Eccher
2015-12-11 20:11 ` Al Viro [this message]
2015-12-11 21:12 ` David Eccher
2015-12-11 20:57 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151211201115.GK20997@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=balbi@ti.com \
--cc=d.eccher@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.