From: keith.busch@intel.com (Keith Busch)
Subject: [PATCH] nvme: Allow controllers to specify a min queue depth for CMB
Date: Fri, 11 Dec 2015 20:33:58 +0000 [thread overview]
Message-ID: <20151211203358.GA24365@localhost.localdomain> (raw)
In-Reply-To: <20151211202546.GA4116@localhost.localdomain>
On Fri, Dec 11, 2015@01:25:46PM -0700, Jon Derrick wrote:
> Hi Christoph,
>
> > - please don't overload the quirks bitmap with actual values
> I agree it may not have been the best place for it, but I wasn't sure how/where it could go to be matched with specific devices. Certain devices may want 8, 16, or 32.
IMHO, I think these need to be tunable from sysfs. There are several
ideas on carving up CMB for various purposes, and don't think we can
let the driver make these policy decisions for the user.
> > - why do we even need to add a quirk? I quick look at the spec
> > doesn't seem to require us to align the submission queue size
> > - this patchs adds a quirk, but no use of it so it's effectively just dead
> > code
> It is not that apparent. It inherits the restriction on the Create I/O Submission Queue command (NVM-Express 1.2a, 5.4, Figure 54).
I just kicked the technical reflector to fix this restriction on CMB
queues. Let's see how that plays out.
next prev parent reply other threads:[~2015-12-11 20:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-11 19:36 [PATCH] nvme: Allow controllers to specify a min queue depth for CMB Jon Derrick
2015-12-11 20:06 ` Christoph Hellwig
2015-12-11 20:25 ` Jon Derrick
2015-12-11 20:33 ` Keith Busch [this message]
2015-12-11 20:59 ` Jon Derrick
2015-12-14 10:18 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151211203358.GA24365@localhost.localdomain \
--to=keith.busch@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.