From: Ken Moffat <zarniwhoop@ntlworld.com>
To: Frederik <frederik.voelkel@fau.de>
Cc: Nicolai Stange <nicstange@gmail.com>,
Greg KH <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
jslaby@suse.com, linux-kernel@i4.cs.fau.de, lukas.braun@fau.de
Subject: Re: [PATCH 0/9] Fix checkpatch errors
Date: Sun, 13 Dec 2015 20:31:17 +0000 [thread overview]
Message-ID: <20151213203117.GA1012@milliways> (raw)
In-Reply-To: <20151213182604.GC11792@faumail.uni-erlangen.de>
On Sun, Dec 13, 2015 at 07:26:04PM +0100, Frederik wrote:
> On Sun, 13. Dec 19:15, Nicolai Stange wrote:
> > Frederik <frederik.voelkel@fau.de> writes:
> >
> > W/o your series applied (so line numbering might be slightly
> > different), checkpatch.pl says:
> >
> > ERROR: trailing whitespace
> > #270: FILE: -:270:
> > +^I * This do { } while() loop will get ALL chars out of Rx FIFO $
> >
> > AFAICS, your patch [7/9] ("drivers: tty: 68328serial.c: remove trailing
> > whitespaces") doesn't fix this one.
> >
> > In good old regexp tradition, the '$' sign denotes the end of line. So,
> > there is a single space after "FIFO" and before the end of line.
> >
> > If you happen to be Emacs users, consider trying out whitespace-mode.
> > If not, try to find another way to make your editor visualize whitespace
> > somehow.
>
> Oh right I see. We will fix that and resend.
>
> Thank you!
If you are using vim, I have the following in my .vimrc. It was
originally posted here many years ago. Seems to work on all my x86
boxes, but AFAIR it didn't work on a ppc, so might not work on other
architectures.
"for redundant whitespace, from Jeremy Kerr via Olof Johanson
highlight RedundantWhitespace ctermbg=red guibg=red
match RedundantWhitespace /\s\+$\| \+\ze\t/
HTH
ĸen
--
This email was written using 100% recycled letters.
next prev parent reply other threads:[~2015-12-13 20:31 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-11 10:36 [PATCH 0/9] Fix checkpatch errors Frederik Völkel
2015-12-11 10:36 ` [PATCH 1/9] drivers: tty: 68328serial.c: Add missing spaces(checkpatch) Frederik Völkel
2015-12-11 10:36 ` [PATCH 2/9] drivers: tty: 68328serial.c: remove unnecessary spaces(checkpatch) Frederik Völkel
2015-12-11 10:36 ` [PATCH 3/9] drivers: tty: 68328serial.c: Do not initialize statics to 0 Frederik Völkel
2015-12-11 10:36 ` [PATCH 4/9] drivers: tty: 68328serial.c: Fix "foo * bar" should be "foo *bar" Frederik Völkel
2015-12-11 10:36 ` [PATCH 5/9] drivers: tty: 68328serial.c: Remove parentheses after return Frederik Völkel
2015-12-11 10:36 ` [PATCH 6/9] drivers: tty: 68328serial.c: Use tabs for indentation Frederik Völkel
2015-12-13 7:08 ` Greg KH
2015-12-13 7:09 ` Greg KH
2015-12-11 10:36 ` [PATCH 7/9] drivers: tty: 68328serial.c: remove trailing whitespaces Frederik Völkel
2015-12-11 10:36 ` [PATCH 8/9] drivers: tty: 68328serial.c: Use use same indentation for switch/case Frederik Völkel
2015-12-11 10:36 ` [PATCH 9/9] drivers: tty: 68328serial.c: Move trailing statements to next line Frederik Völkel
2015-12-13 7:06 ` [PATCH 0/9] Fix checkpatch errors Greg KH
2015-12-13 17:44 ` Frederik
2015-12-13 18:15 ` Nicolai Stange
2015-12-13 18:26 ` Frederik
2015-12-13 20:31 ` Ken Moffat [this message]
2015-12-16 15:16 ` [PATCH v2 0/4] " Frederik Völkel
2015-12-16 15:16 ` [PATCH v2 1/4] drivers: tty: 68328serial.c: Use tabs for indentation Frederik Völkel
2015-12-16 15:43 ` One Thousand Gnomes
2015-12-16 16:25 ` Peter Hurley
2015-12-16 15:16 ` [PATCH v2 2/4] drivers: tty: 68328serial.c: remove trailing whitespaces Frederik Völkel
2015-12-16 15:17 ` [PATCH v2 3/4] drivers: tty: 68328serial.c: Use use same indentation for switch/case Frederik Völkel
2015-12-16 15:17 ` [PATCH v2 4/4] drivers: tty: 68328serial.c: Move trailing statements to next line Frederik Völkel
2015-12-18 11:28 ` [PATCH] serial: Remove 68328 driver Frederik Völkel
2015-12-18 14:27 ` Geert Uytterhoeven
2015-12-18 14:27 ` Geert Uytterhoeven
2016-01-04 5:03 ` Greg Ungerer
2016-01-04 10:30 ` One Thousand Gnomes
2016-01-04 11:10 ` Greg Ungerer
2016-01-11 17:57 ` Peter Hurley
2016-01-11 17:53 ` Peter Hurley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151213203117.GA1012@milliways \
--to=zarniwhoop@ntlworld.com \
--cc=frederik.voelkel@fau.de \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.com \
--cc=linux-kernel@i4.cs.fau.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=lukas.braun@fau.de \
--cc=nicstange@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.